Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not print all RDMA resources to logs #33

Merged
merged 1 commit into from
Aug 9, 2021
Merged

Do not print all RDMA resources to logs #33

merged 1 commit into from
Aug 9, 2021

Conversation

e0ne
Copy link
Collaborator

@e0ne e0ne commented Apr 15, 2021 •
edited
Loading

RDMA resources output doesn't contain a lot of useful information
but floods a logs with thousands of similar records. This patch
changes logs output to print only resources count.

Signed-off-by: Ivan Kolodyazhny ikolodiazhny@nvidia.com

@coveralls
Copy link

coveralls commented Apr 15, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 107

  • 8 of 10 (80.0%) changed or added relevant lines in 1 file are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.3%) to 85.101%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/resources/server.go 8 10 80.0%
Files with Coverage Reduction New Missed Lines %
pkg/resources/resources_manager.go 3 94.81%
Totals Coverage Status
Change from base Build 103: -0.3%
Covered Lines: 674
Relevant Lines: 792
💛 - Coveralls

@e0ne e0ne force-pushed the dev-length branch 2 times, most recently from 9008ba4 to e159fd7 Compare April 15, 2021 09:50
@Mmduh-483
Copy link
Contributor

Mmduh-483 commented Apr 25, 2021 •
edited
Loading

Can you print one of the resources then their count, also check the failing ci
apart from this /lgtm

@adrianchiris
Copy link
Collaborator

hmm not sure why would CI fail on this change.

[Fail] ResourcesManger DiscoverHostDevices [It] Discover devices in host 
/home/travis/gopath/src/github.com/Mellanox/k8s-rdma-shared-dev-plugin/.gopath/src/github.com/Mellanox/k8s-rdma-shared-dev-plugin/pkg/resources/resources_manager_test.go:395

overall im LGTM on this

@adrianchiris
Copy link
Collaborator

Hmm, im also seeing a gzip header issue which i think comes from ghw pci lib.

we encountered this in sriov-network-operator. @e0ne could you try adding to .travis ci file in before-install the followiong:

  • sudo apt-get update -qq
  • sudo apt-get install hwdata -yq

@e0ne
Copy link
Collaborator Author

e0ne commented Apr 27, 2021

Hmm, im also seeing a gzip header issue which i think comes from ghw pci lib.

we encountered this in sriov-network-operator. @e0ne could you try adding to .travis ci file in before-install the followiong:

  • sudo apt-get update -qq
  • sudo apt-get install hwdata -yq

Thanks for the help, @adrianchiris. I'll update my PR with it

@adrianchiris
Copy link
Collaborator

@e0ne can you update the PR (e.g tweak commit msg) to trigger GithubActions ? once it passes we can merge this IMO

@e0ne
Do not print all RDMA resources to logs
7cff4de 
RDMA resources output doesn't contain a lot of useful information
but floods a logs with a huge amount of similar records. This patch
changes logs output to print only resources count.

Signed-off-by: Ivan Kolodyazhny <ikolodiazhny@nvidia.com>
@e0ne
Copy link
Collaborator Author

e0ne commented Aug 9, 2021

@adrianchiris could you please take a look on this once more?

@adrianchiris adrianchiris merged commit ad6b00e into Mellanox:master Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrianchiris adrianchiris adrianchiris approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@e0ne @coveralls @Mmduh-483 @adrianchiris