Add config field for periodic update interval #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 100
💛 - Coveralls |
Mmduh-483
force-pushed
the
config-periodic-interval
branch
4 times, most recently
from
340b1d3
to
a00be45
Compare
adrianchiris
requested changes
Nov 17, 2020
Mmduh-483
force-pushed
the
config-periodic-interval
branch
from
a00be45
to
cc27c09
Compare
adrianchiris
requested changes
Nov 19, 2020
README.md
Outdated
| @@ -97,6 +98,9 @@ The plugin has several configuration fields, this section explains each field us | |||
| } | |||
| ``` | |||
|
|
|||
| `periodicUpdateInterval` is the time interval in seconds to update the resouces accourding to host devices changes if there changed. | |||
| Note: if `periodicUpdateInterval` is 0 then periodic update for host devices will be disabled. | |||
There was a problem hiding this comment.
This breaks current default behaviour.
There was a problem hiding this comment.
If 0 then use current default value?
There was a problem hiding this comment.
how will you disable it ?
There was a problem hiding this comment.
then go routine of periodic will not run, since the condition of the periodic interval is not positive, check here:
https://github.com/Mellanox/k8s-rdma-shared-dev-plugin/blob/master/pkg/resources/resources_manager.go#L288
Mmduh-483
force-pushed
the
config-periodic-interval
branch
from
cc27c09
to
91bf00c
Compare
| @@ -77,7 +77,8 @@ var _ = Describe("ResourcesManger", func() { | |||
| "deviceIDs": ["1017"], | |||
| "ifNames": ["ib2", "ib3"]} | |||
| } | |||
| ]}` | |||
| ], | |||
| "periodicUpdateInterval": 60}` | |||
There was a problem hiding this comment.
can you add a test for the default value as well ?
and this should preferrably be changed to a different value (other than the default)
This change brings a new config field which is used to config the periodic update interval of the device plugin. When periodic update interval is 0 periodic update is disabled Signed-off-by: Mamduh Alassi <mamduhala@mellanox.com>
Mmduh-483
force-pushed
the
config-periodic-interval
branch
from
91bf00c
to
5aa3f43
Compare
adrianchiris
approved these changes
Nov 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change brings a new config field which is used to config the periodic update interval of the device plugin.
When periodic update interval is 0 periodic update is disabled
Fixes #27