Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write date in checkpoint #883

Closed

Conversation

developer0hye
Copy link
Contributor

@developer0hye developer0hye commented Nov 7, 2021

Write date in checkpoint

If we write date in checkpoint file, we may more easily manage the version of the weights file.

I also contributed to the yolov5 project with this idea.

ultralytics/yolov5#5513

ultralytics/yolov5#5514

Write date in checkpoint

If we write date in checkpoint file, we may more easily manage the version of the weights file.
@CLAassistant
Copy link

CLAassistant commented Nov 7, 2021

CLA assistant check
All committers have signed the CLA.

@FateScript
Copy link
Member

ctime of file could help. Why not tring version number?

@developer0hye
Copy link
Contributor Author

@FateScript
When we share the weight file, the ctime could be changed so I thought that writing the date in the checkpoint file will resolve this issue.

@FateScript
Copy link
Member

Please lint your code to pass the workflow, I will merge this pr if workflow success. @developer0hye

@developer0hye
Copy link
Contributor Author

@FateScript
Thanks for your review! But if you still think that it is not a good idea, you don't need to merge this PR. Simple is the best!

@FateScript
Copy link
Member

@developer0hye After discussion with others, we decide to close this PR. Thanks for contribution anyway.

@FateScript FateScript closed this Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants