Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add option for decode output in export_onnx.py #1113

Merged

Conversation

wep21
Copy link
Contributor

@wep21 wep21 commented Feb 5, 2022

No description provided.

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
@wep21
Copy link
Contributor Author

wep21 commented Feb 5, 2022

@FateScript Could you review this?

@FateScript
Copy link
Member

Thx for contribution. Could you plz tell us why it's needed?

@wep21
Copy link
Contributor Author

wep21 commented Feb 11, 2022

@FateScript TensoRT now supports ScatterND and NMS plugin, so the decode part generated from export_onnx.py can be directly converted to tensorrt engine file.
https://docs.nvidia.com/deeplearning/tensorrt/container-release-notes/rel_21-07.html
Screenshot from 2022-02-11 20-28-51

@FateScript
Copy link
Member

@wep21 Did you try export nms and run it suceessfully(with the correct output)?

@FateScript FateScript self-requested a review February 16, 2022 08:51
@wep21
Copy link
Contributor Author

wep21 commented Mar 1, 2022

@FateScript Yes, I have tested it with my ros2 implementation. https://github.com/tier4/tensorrt_yolox
Is it preferable to share some python codes to reproduce this?

@FateScript
Copy link
Member

@FateScript Yes, I have tested it with my ros2 implementation. https://github.com/tier4/tensorrt_yolox Is it preferable to share some python codes to reproduce this?

Thx, I could have a try myself.

@FateScript
Copy link
Member

LGTM.

@FateScript FateScript merged commit babb80e into Megvii-BaseDetection:main Mar 2, 2022
@wep21 wep21 deleted the feature/decode-in-export-onnx branch March 2, 2022 06:43
@jbohnslav
Copy link

Hello @wep21, can you describe how you got the ONNX graph above? NMS happens in yolox.utils.boxes.py::postprocess. When I add this function to my forward pass, it doesn't use the EfficientNMS_TRT node.

Did you use a ONNX graph surgeon?

@wep21
Copy link
Contributor Author

wep21 commented Jan 13, 2023

@jbohnslav Yes, I created a conversion script with onnx graph surgeon.
https://github.com/wep21/yolox_onnx_modifier

Githubinme pushed a commit to Githubinme/YOLOX that referenced this pull request Jun 6, 2023
…Detection#1113)

feat(tools): add option for decode output in export_onnx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants