Skip to content

Commit

Permalink
inspector: migrate node to js_protocol.pdl
Browse files Browse the repository at this point in the history
On inspector side we are going to deprecate .json protocol
definition formation and replace it with new .pdl format.
New format allows us to use multiline commends and contains less
noise in comparision then .json.

PR-URL: nodejs#20141
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@keybase.io>
  • Loading branch information
alexkozy authored and MayaLekova committed May 8, 2018
1 parent 05bfa7e commit a79eed3
Showing 1 changed file with 22 additions and 1 deletion.
23 changes: 22 additions & 1 deletion node.gyp
Original file line number Diff line number Diff line change
Expand Up @@ -672,11 +672,32 @@
'conditions': [
[ 'v8_enable_inspector==1', {
'actions': [
{
'action_name': 'v8_inspector_copy_protocol_to_intermediate_folder',
'inputs': [ 'deps/v8/src/inspector/js_protocol.pdl' ],
'outputs': [ '<(SHARED_INTERMEDIATE_DIR)/js_protocol.pdl' ],
'action': [ 'cp', '<@(_inputs)', '<(SHARED_INTERMEDIATE_DIR)' ],
},
{
'action_name': 'v8_inspector_convert_protocol_to_json',
'inputs': [
'<(SHARED_INTERMEDIATE_DIR)/js_protocol.pdl',
],
'outputs': [
'<(SHARED_INTERMEDIATE_DIR)/js_protocol.json',
],
'action': [
'python',
'deps/v8/third_party/inspector_protocol/ConvertProtocolToJSON.py',
'<@(_inputs)',
'<@(_outputs)',
],
},
{
'action_name': 'v8_inspector_compress_protocol_json',
'process_outputs_as_sources': 1,
'inputs': [
'deps/v8/src/inspector/js_protocol.json',
'<(SHARED_INTERMEDIATE_DIR)/js_protocol.json',
],
'outputs': [
'<(SHARED_INTERMEDIATE_DIR)/v8_inspector_protocol_json.h',
Expand Down

0 comments on commit a79eed3

Please sign in to comment.