Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround for Species enum containing both keys and values #11

Merged
merged 1 commit into from
Oct 9, 2020

Conversation

abend
Copy link
Contributor

@abend abend commented Sep 11, 2020

Hi. This is a quick fix for #10. I can rework it or otherwise make changes if you like. This got me up and running again.

Thanks!

@mtskillman
Copy link

change line 236 of js/render.js to
universe.paint(Species.Air, 0, 2, Species.Air);

"Species" instead of "species"

@mtskillman
Copy link

i cherry-picked your commit and added the change mentioned above, as well:
#12

@MaxBittker
Copy link
Owner

hey! thanks for the fix :-)

I'm guessing this was a change from wasm-bindgen, not sure why they chose this new behavior.

@MaxBittker MaxBittker merged commit 0b22f45 into MaxBittker:master Oct 9, 2020
@MaxBittker
Copy link
Owner

it was this change... rustwasm/wasm-bindgen#2240

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants