Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DAG-CBOR map keys order for encoding and decoding #18

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

MarshalX
Copy link
Owner

@MarshalX MarshalX commented Mar 1, 2024

No description provided.

Copy link

codspeed-hq bot commented Mar 1, 2024

CodSpeed Performance Report

Merging #18 will improve performances by 41.51%

Comparing fix-map-keys-order (e2d9155) with main (10e190d)

Summary

⚡ 3 improvements
✅ 59 untouched benchmarks

Benchmarks breakdown

Benchmark main fix-map-keys-order Change
test_dag_cbor_encode_real_data[citm_catalog.json] 162.6 ms 125.3 ms +29.78%
test_dag_cbor_encode_real_data[github.json] 6.1 ms 4.8 ms +27.12%
test_dag_cbor_encode_real_data[twitter.json] 56.2 ms 39.7 ms +41.51%

@MarshalX MarshalX merged commit cf04486 into main Mar 1, 2024
18 checks passed
@MarshalX MarshalX deleted the fix-map-keys-order branch March 1, 2024 23:52
@MarshalX
Copy link
Owner Author

MarshalX commented Mar 2, 2024

ofc perf degradation because of new additional checks and sorts are here too. 3-7% for both encoding and decoding. you can see it in the detailed CodSpeed report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant