Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate syntax sugar for repo operations upon records #266

Merged
merged 6 commits into from
Feb 4, 2024
Merged

Integrate syntax sugar for repo operations upon records #266

merged 6 commits into from
Feb 4, 2024

Conversation

MarshalX
Copy link
Owner

@MarshalX MarshalX commented Feb 3, 2024

No description provided.

@MarshalX
Copy link
Owner Author

MarshalX commented Feb 3, 2024

i dont like it so bad how it works with response models...

@MarshalX
Copy link
Owner Author

MarshalX commented Feb 3, 2024

why not place these models directly right after the record model itself?

  • 1 shared model for sync and async
  • models stay in the "models" module only
  • shortcuts to models will work great with it

instead of async_ns.PostRecord.CreateRecordResponse we will have typical models import as we had before: models.AppBskyFeedPost.CreateRecordResponse. and the record itself is models.AppBskyFeedPost.Record

@MarshalX MarshalX changed the title Integrate Record syntax sugar Integrate syntax sugar for repo operations upon records Feb 4, 2024
@MarshalX MarshalX merged commit fddf9ac into main Feb 4, 2024
25 checks passed
@MarshalX MarshalX deleted the migrate-to-record-syntax-sugar branch February 4, 2024 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@MarshalX