Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
not sure yet about it. new structure solves depending on the root package. for example on the old structure codegen depends on xrpc_client models... that codegen generates... (because of import aliases in the root package)
this PR breaks compatibility. update of imports are required
instead of
from atproto.firehose import ...
now we must usefrom atproto_firehose import ...
(replace . to _)some of aliases provided by
atproto
package:it means that imports like
from atproto import Client
will work fine without changesnew (completely different packages at the top of project):
old (one root package called "atproto" and many modules):