Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix M115 parsing #27050

Closed

Conversation

kisslorand
Copy link
Contributor

Description

PR #26806 broke the parsing of the printer's name ("MACHINE_TYPE:") on some printers. (The parsing is done by extracting the text between "MACHINE_TYPE:" and "EXTRUDER_COUNT:".) This PR fixes this issue.

The parameter "KINEMATICS:" is moved to a place where it is preceded by numerical values (extruder count or axis count) so it does not interfere with parsing of the extruder count and/or axis count.

@thisiskeithb
Copy link
Member

thisiskeithb commented May 3, 2024

I've already patched this in BTT's TFT firmware: bigtreetech/BIGTREETECH-TouchScreenFirmware#2913

This PR now breaks the printer name in their firmware again.

@thisiskeithb thisiskeithb added Needs: Discussion Discussion is needed S: Don't Merge Work in progress or under discussion. labels May 3, 2024
@kisslorand
Copy link
Contributor Author

There are numerous printers with other FW than the one mentioned. It's best practice to address the underlying cause of an issue rather than just its immediate effect.

@thisiskeithb
Copy link
Member

thisiskeithb commented May 3, 2024

There are numerous printers with other FW than the one mentioned. It's best practice to address the underlying cause of an issue rather than just its immediate effect.

Can you provide an example? My fix is backward compatible with older & newer versions of Marlin.

@kisslorand
Copy link
Contributor Author

An example would be any random custom firmware. (ex.: https://www.thingiverse.com/thing:4294049)

@thisiskeithb
Copy link
Member

An example would be any random custom firmware. (ex.: https://www.thingiverse.com/thing:4294049)

They just need to pull in the latest TFT firmware from BTT's repo.

@digant73: Don't forget to update your fork(s) 😄

@kisslorand
Copy link
Contributor Author

Than we're back what I've just said: "It's best practice to address the underlying cause of an issue rather than just its immediate effect."

@thisiskeithb
Copy link
Member

Than we're back what I've just said: "It's best practice to address the underlying cause of an issue rather than just its immediate effect."

This PR is just a workaround when the actual fix has already been applied to BTT's TFT firmware.

Update your TFT firmware to the latest version and you'll be set.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Discussion Discussion is needed S: Don't Merge Work in progress or under discussion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants