-
-
Notifications
You must be signed in to change notification settings - Fork 19.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Power Loss Recovery ISR overwrite Fix #26365
Merged
thinkyhead
merged 14 commits into
MarlinFirmware:bugfix-2.1.x
from
ThomasToka:bugfix-2.1.x-powerloss-fix
Jan 12, 2024
Merged
Power Loss Recovery ISR overwrite Fix #26365
thinkyhead
merged 14 commits into
MarlinFirmware:bugfix-2.1.x
from
ThomasToka:bugfix-2.1.x-powerloss-fix
Jan 12, 2024
Commits on Oct 22, 2023
-
This patch fixes the following problems: - on resume the print restarts from the beginning - on resume the movements are slow - on resume the extruder sometimes extrudes a lot of filament on the resume position background here is that info.current_position (which are for x,y,z,e saved positions) and info.sdpos are overwritten inside of stepper.cpp. This in some situations leads to the mentioned problems on the power loss recovery run. Todo: Resume to the exact last position. I think something is still missing here.
Configuration menu - View commit details
-
Copy full SHA for f99da6c - Browse repository at this point
Copy the full SHA f99da6cView commit details -
I think i found the reason for Z. info.current_position.z may be wrong, depending on when isr overwrites it. current_position.z should be right.
Configuration menu - View commit details
-
Copy full SHA for c401ed2 - Browse repository at this point
Copy the full SHA c401ed2View commit details -
Configuration menu - View commit details
-
Copy full SHA for efd2064 - Browse repository at this point
Copy the full SHA efd2064View commit details -
Configuration menu - View commit details
-
Copy full SHA for 35fe5f5 - Browse repository at this point
Copy the full SHA 35fe5f5View commit details -
Configuration menu - View commit details
-
Copy full SHA for f9d6a71 - Browse repository at this point
Copy the full SHA f9d6a71View commit details
Commits on Oct 23, 2023
-
Configuration menu - View commit details
-
Copy full SHA for c28357f - Browse repository at this point
Copy the full SHA c28357fView commit details -
Configuration menu - View commit details
-
Copy full SHA for ddb5166 - Browse repository at this point
Copy the full SHA ddb5166View commit details -
Configuration menu - View commit details
-
Copy full SHA for 372ce49 - Browse repository at this point
Copy the full SHA 372ce49View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1932b0c - Browse repository at this point
Copy the full SHA 1932b0cView commit details
Commits on Jan 7, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 84d5811 - Browse repository at this point
Copy the full SHA 84d5811View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3026cc4 - Browse repository at this point
Copy the full SHA 3026cc4View commit details
Commits on Jan 10, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 333d931 - Browse repository at this point
Copy the full SHA 333d931View commit details -
Configuration menu - View commit details
-
Copy full SHA for 99caea5 - Browse repository at this point
Copy the full SHA 99caea5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3564086 - Browse repository at this point
Copy the full SHA 3564086View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.