Fully support DISPLAY statement

[Claes65]

No description provided.

[Claes65]

I welcome you to pull my branch and make the changes you want- I am sure it won’t take you more than 5 minutes, and then I can have my aha moments ;)

[MarkusAmshove]

I did the changes in your branch.

Previously, you had the OutputStatementNode class implement different statement interfaces (IWriteNode, IDisplayNode).

That would lead to the following confusion/bug:

If you write an analyzer for WRITE statements - lets pretend you want to do a "Don't use WRITE, use DISPLAY instead" diagnostic - then you will register the analyzer to analyze IWriteNodes.
The problem you'd have then, is that the statements that you get might not only be WRITE statements, but also DISPLAY statements, because OutputStatementNode implements both and is constructed for both.

With my change we have some empty classes and interfaces, which is strange and maybe not nice but accomplishes the distinction.
Now only WriteNode implements IWriteNode and only DisplayNode implements IDisplayNode. Their implementation is identical (empty classes in this case, because they both extend OutputStatementNode), but the distinction is important :-)

[Claes65]

@MarkusAmshove - looks great, so trick was to replace extends IStatementNode with IOutputStatementNode :)

I've now installed Java 21, and made a comparison. I get some new diagnostics: Need to support the DISPLAY options VERT and HORIZ. Should I implement this in consumeInputOutputOperand similar to TAB_SETTING etc? Or is there a better way? Really, we just don't want them to be seen as Identifiers, because they are reported as "Unknown reference".
edit: I have resolved this in latest commit, I hope.

Also I see a lot of Maps with Unterminated String literal, expecting closing [""]"

[Claes65]

@MarkusAmshove did you test this yet?

[MarkusAmshove]

I pushed the changes but didn't test anything further, because the PR is still flagged as WIP :)

[MarkusAmshove]

VERT AS works now :)

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
88.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud