Update contributors table and remove unnecessary margin top #2031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Overview of changes:
After the upstream change has been merged (all-contributors/cli#307), the all-contributors tooling now generates HTML table with
<tbody>, hence fixing the previous hydration issue in the about page. Thus,Anything you'd like to highlight/discuss:
The bot is also updated, so usage on GitHub UI will work correctly as well.
Testing instructions:
Check the about page and the README to see the content rendered correctly.
https://deploy-preview-2031--markbind-master.netlify.app/about.html
https://github.com/tlylt/markbind/blob/fix-contrib/README.md
Additionally, after the PR has been merged, can try to invoke the bot to see if the change is correct.
Proposed commit message: (wrap lines at 72 characters)
Update contributors table and remove unnecessary margin-top
Checklist: ☑️