MDEV-34141: Implements the function ST_Simplify #3376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note, new error messages go at the end as they are numbered in order of the file. This seems to be the cause of most MTR test failures. |
StefanoPetrilli
force-pushed
the
11.6-MDEV-34141
branch
5 times, most recently
from
6f6d637
to
5b4be6b
Compare
StefanoPetrilli
changed the base branch from
11.6
to
bb-11.7-mdev-34120-gis-functions
StefanoPetrilli
force-pushed
the
11.6-MDEV-34141
branch
from
5b4be6b
to
43064a3
Compare
StefanoPetrilli
force-pushed
the
11.6-MDEV-34141
branch
from
43064a3
to
2108ede
Compare
The GIS function ST_Simplify takes ad input a geometry and a double. It applies the Ramer-Douglas-Peucker algorithm on the geometry and returns the resulting geometry. The tests have been cherry-picked from the MySQL implementation of this function to grant compatibility among the two implementations. Co-authored-by: David Zhao <david.zhao@oracle.com> Co-authored-by: Pavan Naik <pavan.naik@oracle.com> Co-authored-by: Norvald H. Ryeng <norvald.ryeng@oracle.com> Co-authored-by: Erlend Dahl <erlend.dahl@oracle.com> Co-authored-by: Jon Hauglid <jon.hauglid@oracle.com> Co-authored-by: Hans H Melby <hans.h.melby@oracle.com> Co-authored-by: Tor Didriksen <tor.didriksen@oracle.com>
StefanoPetrilli
force-pushed
the
11.6-MDEV-34141
branch
from
2108ede
to
c95063f
Compare
DaveGosselin-MariaDB
merged commit 8c51e63
into
MariaDB:bb-11.7-mdev-34120-gis-functions
14 of 16 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
MariaDB GIS functionalities are limited when compared to other DBMs. To facilitate the migration from MySQL to MariaDB the GIS functionality should be the same. This PR implements the GIS function
ST_Simplify(Geometry g, double max_distance). It applies the Ramer–Douglas–Peucker algorithm ongand returns the resulting geometry.The goal of the Douglas-Peucker algorithm is to find a geometry that is similar to
gbut uses only a subset of points. The algorithm may produce self-intersections and therefore result in invalid geometries.If the
max_distanceis not positive or is NULL, an ER_WRONG_ARGUMENT will occur. The same function is also accessible usingsimplify(Geometry g1, double max_distance).To ensure compatibility between the MySQL implementation of this function and the MariaDB implementation, the tests for this function have been cherry-picked from MySQL.
This patch has no side effects.
Release Notes
Adds the function:
ST_Simplify(Geometry g, double max_distance),Simplify(Geometry g, double max_distance): returns the simplified version of g using the Ramer–Douglas–Peucker algorithms.How can this PR be tested?
An extensive test suite has been cherry-picked from MySQL.
Basing the PR against the correct MariaDB version
PR quality check