Fix: incorrect unless condition

test/wrapper_test.rb

@@ -3070,9 +3070,9 @@ def test_assert_inapplicable_relations
 
     vrp = TestHelper.create(problem)
     assert_includes OptimizerWrapper.config[:services][:vroom].inapplicable_solve?(vrp),
-                    :assert_no_relations_except_simple_shipments
-    refute_includes OptimizerWrapper.config[:services][:ortools].inapplicable_solve?(vrp),
-                    :assert_no_relations_except_simple_shipments
+                    :assert_no_overall_duration
+    assert_includes OptimizerWrapper.config[:services][:ortools].inapplicable_solve?(vrp),
+                    :assert_no_overall_duration
 
     problem = VRP.basic
     problem[:relations] = [{

wrappers/ortools.rb

@@ -69,7 +69,7 @@ def solver_constraints
         :assert_route_date_or_indice_if_periodic,
         :assert_not_too_many_visits_in_route,
         :assert_no_route_if_schedule_without_periodic_heuristic,
-        # :assert_no_overall_duration, # TODO: Requires a complete rework
+        :assert_no_overall_duration, # TODO: Requires a complete rework
       ]
     end
 

wrappers/vroom.rb

@@ -62,6 +62,7 @@ def solver_constraints
         :assert_vehicles_no_late_multiplier_or_single_vehicle,
         :assert_vehicles_no_overload_multiplier,
         :assert_vehicles_start_or_end,
+        :assert_no_overall_duration,
 
         # Mission constraints
         :assert_no_activity_with_position,

wrappers/wrapper.rb

@@ -148,7 +148,8 @@ def assert_one_sticky_at_most(vrp)
     def assert_no_relations_except_simple_shipments(vrp)
       vrp.relations.all?{ |r|
         next true if r.linked_ids.empty? && r.linked_vehicle_ids.empty?
-        next false unless r.type == :shipment && r.linked_ids.size == 2
+        next true unless r.type == :shipment
+        next false unless r.linked_ids.size == 2
 
         quantities = Hash.new {}
         vrp.units.each{ |unit| quantities[unit.id] = [] }