Updated to dbus-0.8.1 and fixed PlayerEvents being referenced by Player::events but not re-exported.
#48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ccuring. Note: due to a compiler error, the root-level `metadata` re-exports had to be split into 3; see rust-lang/rust#64762
|
Thank you! I'll take a look at this as soon as I'm able to. |
|
This looks really good. Thank you so much! ❤️ I've squashed and reworded a few commits, but you retain all authorship of the code still. Merged here: 002ebdf |
|
Version 2.0.0-rc2 was just released with this fix included. Please let me know if it works for you so I can release as 2.0.0. |
|
Thanks! I'll let you know once I have time. |
|
Everything seems okay on my end. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PlayerEvents was not actually re-exported at the crate root, so
Player::eventscouldn't actually be used. I fixed that and added theunreachable_publint to (hopefully) catch similar issues in the future, but it's worth noting that the lint has a bug right now for certain use cases; see rust issue #64762.I also updated dbus while I was at it, which required a bunch of import changes since a lot of the previous api got moved to
dbus::ffidisp.