Add OpenShift Virtualization vendor types for VMs and hosts #23165
+21
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
Checked commit nasark@a9643b9 with ruby 3.1.5, rubocop 1.56.3, haml-lint 0.51.0, and yamllint |
Fryguy
approved these changes
Aug 29, 2024
|
@nasark Does this depend on ManageIQ/manageiq-providers-openshift#264 or is it the other way around? |
|
I think it is the other way around, that provider PR can't go green without this |
|
Yes it's the other way around |
agrare
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These will be needed after the introduction of the OSV provider as its own separate provider
Needed for:
@miq-bot assign @agrare
@miq-bot add_label enhancement, providers, radjabov/yes?
@miq-bot add_reviewer @agrare