Remove ContainerGroup#old_container_project_id #22610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbrock
force-pushed
the
drop_old_container_project
branch
from
919340d
to
aa735cc
Compare
We use deleted_on to represent a record that is deleted. We moved over to using archived (deleted_on) from old_container_project_id Convert all_container_groups to a regular association see also: - f6fe251 - ManageIQ#16302
kbrock
force-pushed
the
drop_old_container_project
branch
from
aa735cc
to
7201ab4
Compare
|
update:
update:
|
when fetching container groups from a container_project, it was not assigning the reverse association added `inverse_of` to get them assigned (and avoid N+1) changed ext_management_system class to one that had the `container_projects` reference
kbrock
force-pushed
the
drop_old_container_project
branch
from
7201ab4
to
5ebb1ed
Compare
|
update:
|
|
Checked commits kbrock/manageiq@eacae91~...171bace with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint app/models/container_project.rb
|
|
update:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use deleted_on to represent a record that is deleted. We moved over to using archived (deleted_on) from old_container_project_id
see also: