Enable notifier role by default #22587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's easy to configure smtp and not realize you need to enable this role to get email functionality working. See also: ManageIQ#10504 ManageIQ/manageiq-ui-classic#2079
|
Checked commit jrafanie@178ac1f with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint |
|
@miq-bot cross-repo-test /all |
miq-bot
pushed a commit
to ManageIQ/manageiq-cross_repo-tests
that referenced
this pull request
Jun 28, 2023
From Pull Request: ManageIQ/manageiq#22587
jrafanie
added a commit
to jrafanie/manageiq
that referenced
this pull request
Jun 28, 2023
Followup to ManageIQ#22587 Enabling notifier but forgetting to set smtp settings isn't technically an error but it's an application problem. The same can be said if you configure smtp but don't enable notifier. Previously, we could only prevent saving configuration if it was invalid. Now, we can notify someone who might be able to fix the problem. TODO: We still have errors about notifications without duplicate messages.
jrafanie
added a commit
to jrafanie/manageiq
that referenced
this pull request
Jun 28, 2023
Followup to ManageIQ#22587 Enabling notifier but forgetting to set smtp settings isn't technically an error but it's an application problem. The same can be said if you configure smtp but don't enable notifier. Previously, we could only prevent saving configuration if it was invalid. Now, we can notify someone who might be able to fix the problem. TODO: We still have errors about notifications without duplicate messages.
|
Only failure in cross repo seems to be an unrelated cic error |
|
Backported to |
Fryguy
pushed a commit
that referenced
this pull request
Jul 25, 2023
Enable notifier role by default (cherry picked from commit 80beb4b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's easy to configure smtp and not realize you need to enable this role to get email functionality working.
See also:
#10504
ManageIQ/manageiq-ui-classic#2079