Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow po_to_json from ui classic #22438

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

jrafanie
Copy link
Member

This will allow us to more easily automate the updates of the json files from the UI classic repository.

@Fryguy
Copy link
Member

Fryguy commented Apr 3, 2023

I think what you're trying to do is run the app namespace if it's available? if so, we have a pattern for that where you just check for the presence of ENGINE_ROOT, for example:

defined?(ENGINE_ROOT) ? "app:test:security" : "test:security"

lib/tasks/locale.rake Outdated Show resolved Hide resolved
lib/tasks/locale.rake Outdated Show resolved Hide resolved
@miq-bot
Copy link
Member

miq-bot commented Jul 17, 2023

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s)

Thank you for all your contributions! More information about the ManageIQ triage process can be found in the triage process documentation.

@Fryguy Fryguy removed the stale label Jul 20, 2023
@Fryguy
Copy link
Member

Fryguy commented Jul 20, 2023

I still think this PR is good, I just think it can be simplified down to https://github.com/ManageIQ/manageiq/pull/22438/files#r1156003653

@miq-bot miq-bot added the stale label Oct 23, 2023
@miq-bot
Copy link
Member

miq-bot commented Oct 23, 2023

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s)

Thank you for all your contributions! More information about the ManageIQ triage process can be found in the triage process documentation.

@kbrock kbrock removed the stale label Oct 23, 2023
@kbrock
Copy link
Member

kbrock commented Oct 23, 2023

I like this PR / Jason's simplification.

@miq-bot miq-bot added the stale label Jan 29, 2024
@miq-bot
Copy link
Member

miq-bot commented Jan 29, 2024

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).

2 similar comments
@miq-bot
Copy link
Member

miq-bot commented May 13, 2024

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).

@miq-bot
Copy link
Member

miq-bot commented Aug 19, 2024

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).

This will allow us to more easily automate the updates of the json files
from within the UI classic repository.
@jrafanie jrafanie force-pushed the allow_po_to_json_from_ui_classic branch from 92e914b to c08f626 Compare September 11, 2024 21:47
@jrafanie
Copy link
Member Author

I've tested this in combination with the pending changes to the pot file in #22294 to verify that only the English pot is changed and contains the relevant changes on master as shown in that PR. I tested this from manageiq and from ui classic.

@jrafanie jrafanie removed the stale label Sep 11, 2024
@jrafanie jrafanie changed the title Allow ui classic to fallback to app namespace for po_to_json Allow po_to_json from ui classic Sep 11, 2024
@miq-bot
Copy link
Member

miq-bot commented Sep 11, 2024

Checked commit jrafanie@c08f626 with ruby 3.1.5, rubocop 1.56.3, haml-lint 0.51.0, and yamllint
1 file checked, 0 offenses detected
Everything looks fine. 👍

@jrafanie jrafanie mentioned this pull request Sep 11, 2024
1 task
@jrafanie jrafanie closed this Sep 11, 2024
@jrafanie jrafanie reopened this Sep 11, 2024
@Fryguy Fryguy merged commit b48b02f into ManageIQ:master Sep 12, 2024
13 of 14 checks passed
@jrafanie jrafanie deleted the allow_po_to_json_from_ui_classic branch September 12, 2024 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants