-
Notifications
You must be signed in to change notification settings - Fork 897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow po_to_json from ui classic #22438
Allow po_to_json from ui classic #22438
Conversation
I think what you're trying to do is run the app namespace if it's available? if so, we have a pattern for that where you just check for the presence of ENGINE_ROOT, for example: defined?(ENGINE_ROOT) ? "app:test:security" : "test:security" |
This pull request has been automatically marked as stale because it has not been updated for at least 3 months. If these changes are still valid, please remove the Thank you for all your contributions! More information about the ManageIQ triage process can be found in the triage process documentation. |
I still think this PR is good, I just think it can be simplified down to https://github.com/ManageIQ/manageiq/pull/22438/files#r1156003653 |
This pull request has been automatically marked as stale because it has not been updated for at least 3 months. If these changes are still valid, please remove the Thank you for all your contributions! More information about the ManageIQ triage process can be found in the triage process documentation. |
I like this PR / Jason's simplification. |
This pull request has been automatically marked as stale because it has not been updated for at least 3 months. If these changes are still valid, please remove the |
2 similar comments
This pull request has been automatically marked as stale because it has not been updated for at least 3 months. If these changes are still valid, please remove the |
This pull request has been automatically marked as stale because it has not been updated for at least 3 months. If these changes are still valid, please remove the |
This will allow us to more easily automate the updates of the json files from within the UI classic repository.
92e914b
to
c08f626
Compare
I've tested this in combination with the pending changes to the pot file in #22294 to verify that only the English pot is changed and contains the relevant changes on master as shown in that PR. I tested this from manageiq and from ui classic. |
Checked commit jrafanie@c08f626 with ruby 3.1.5, rubocop 1.56.3, haml-lint 0.51.0, and yamllint |
This will allow us to more easily automate the updates of the json files from the UI classic repository.