-
Notifications
You must be signed in to change notification settings - Fork 897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[V2V] Use full class name in task context data for conversion hosts #18799
Conversation
@mturley Please take a look. |
@miq-bot add_label bug, transformation |
@miq-bot add_label hammer/yes |
@djberg96 I'm testing this locally and it looks like |
I think this is why it's missing from |
@mturley I was never really sure why that was split out originally. Doesn't seem to be a good reason for it, but I'll just work around it for now. |
@mturley @fdupont-redhat Updated. |
Checked commits https://github.com/djberg96/manageiq/compare/f11ff8209c7868a93ba48072e6c4f69250bc5144~...aa2e02e78494cad789732f51c5b427da4adb65ba with ruby 2.3.3, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 LGTM. Thanks @djberg96
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 LGTM too.
Closing in favor of ManageIQ/manageiq-api#600 |
Originally we set the
resource_type
to the full name, e.g.ManageIQ::Providers::Redhat::InfraManager::Host
, so that we could take advantage of theSupportsFeature
mixin. And so, we added a validation to force the issue.However, that broke Rails polymorphic associations, so we changed the param internally to just the base name, e.g. host, in #18604.
Unfortunately, this also got saved in the context data for the associated task. The upshot is that when a user tries to use the "retry" button, which uses the context data to resubmit the request, there is a validation failure because the resource type is no longer the full name.
So, this PR restores the full resource type in the
context_data
of the associated task internally.https://bugzilla.redhat.com/show_bug.cgi?id=1713394