Fix deleting a disk from VM #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
borod108
changed the title
borod108
force-pushed
the
bugs/fix1666593
branch
2 times, most recently
from
06681ee
to
1fcf320
Compare
borod108
changed the title
masayag
reviewed
Mar 10, 2019
| @@ -272,7 +272,6 @@ def vm_reconfigure(vm, options = {}) | |||
| # Retrieve the current representation of the virtual machine: | |||
| # TODO: no need to retreive vm here, only if memory is updated | |||
| vm = vm_service.get | |||
|
|
|||
There was a problem hiding this comment.
seems this space line is required
Removing a disk was not handled correctly Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1666593
borod108
force-pushed
the
bugs/fix1666593
branch
from
1fcf320
to
70f427f
Compare
|
Checked commit borod108@70f427f with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 spec/models/manageiq/providers/redhat/infra_manager/ovirt_services/strategies/v4_spec.rb
|
masayag
approved these changes
Mar 11, 2019
agrare
reviewed
Mar 11, 2019
| disk_specs.each do |disk_spec| | ||
| attachment_service = attachments_service.attachment_service(disk_spec['disk_name']) | ||
| disk_spec = disk_spec.with_indifferent_access |
There was a problem hiding this comment.
@borod108 just curious, why do you need with_indifferent_access here? Is the 'disk_name' key not always a string ?
There was a problem hiding this comment.
When the request comes from api it is, at least sometimes, a symbol (this was one of the things that went wrong here)
simaishi
pushed a commit
that referenced
this pull request
Mar 12, 2019
Fix deleting a disk from VM (cherry picked from commit c4063dd) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1687846
|
Hammer backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing a disk was not handled correctly
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1666593