Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't use interpolations in gettext strings #297

Merged
merged 1 commit into from
Oct 9, 2018
Merged

Don't use interpolations in gettext strings #297

merged 1 commit into from
Oct 9, 2018

Conversation

mzazrivec
Copy link
Contributor

No description provided.

@mzazrivec
Copy link
Contributor Author

@miq-bot add_label internationalization, hammer/yes

@mzazrivec mzazrivec mentioned this pull request Oct 8, 2018
Merged
@agrare agrare self-assigned this Oct 9, 2018
@agrare agrare merged commit 5b4b5f2 into ManageIQ:master Oct 9, 2018
@agrare agrare added this to the Sprint 97 Ending Oct 22, 2018 milestone Oct 9, 2018
simaishi pushed a commit that referenced this pull request Oct 9, 2018
@agrare @simaishi
Merge pull request #297 from mzazrivec/dont_use_interpolations_in_get…
b28a75e 
…text

Don't use interpolations in gettext strings

(cherry picked from commit 5b4b5f2)
@simaishi
Copy link
Contributor

simaishi commented Oct 9, 2018

Hammer backport details:

$ git log -1
commit b28a75ec8b27eb426b09cce204c8c3746cf723d0
Author: Adam Grare <agrare@redhat.com>
Date:   Tue Oct 9 09:17:29 2018 -0400

    Merge pull request #297 from mzazrivec/dont_use_interpolations_in_gettext
    
    Don't use interpolations in gettext strings
    
    (cherry picked from commit 5b4b5f2e4e94d82a9695b28b07c96c563187ff31)

@mzazrivec mzazrivec deleted the dont_use_interpolations_in_gettext branch October 10, 2018 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pkliczewski pkliczewski pkliczewski approved these changes

@agrare agrare agrare approved these changes

Assignees

@agrare agrare

Labels
hammer/backported internationalization
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mzazrivec @simaishi @pkliczewski @agrare @miq-bot