Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add safe operator for bz 1633540 to protect against empty source_vms #292

Merged
merged 1 commit into from
Sep 27, 2018
Merged

Add safe operator for bz 1633540 to protect against empty source_vms #292

merged 1 commit into from
Sep 27, 2018

Conversation

d-m-u
Copy link
Contributor

@d-m-u d-m-u commented Sep 27, 2018 •
edited
Loading

If the get_source_and_targets[:vm] fails, the source_vms will be nil and maybe we could just use the safe op thingy?

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1633540

@miq-bot
Copy link
Member

miq-bot commented Sep 27, 2018

Checked commit d-m-u@a59637e with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. ⭐

@d-m-u
Copy link
Contributor Author

d-m-u commented Sep 27, 2018

@agrare I've no idea who to assign this to, do you think it's yours?
@miq-bot add_label bug

@miq-bot miq-bot added the bug label Sep 27, 2018
@borod108 borod108 merged commit d16ef35 into ManageIQ:master Sep 27, 2018
@d-m-u
Copy link
Contributor Author

d-m-u commented Sep 27, 2018

@miq-bot add_label hammer/yes

simaishi pushed a commit that referenced this pull request Oct 1, 2018
@borod108 @simaishi
Merge pull request #292 from d-m-u/add_safe_op_to_allowed_customizati…
13638b4 
…on_templates_check

Add safe operator for bz 1633540 to protect against empty source_vms

(cherry picked from commit d16ef35)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1633540
@simaishi
Copy link
Contributor

simaishi commented Oct 1, 2018

Hammer backport details:

$ git log -1
commit 13638b41270352ef87d0b5ed5692f3d8b957c47f
Author: Boris Od <boris.od@gmail.com>
Date:   Thu Sep 27 19:15:16 2018 +0300

    Merge pull request #292 from d-m-u/add_safe_op_to_allowed_customization_templates_check
    
    Add safe operator for bz 1633540 to protect against empty source_vms
    
    (cherry picked from commit d16ef357b6db0abdca1360c43a3d67f52a28aa2d)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1633540

@d-m-u d-m-u deleted the add_safe_op_to_allowed_customization_templates_check branch October 1, 2018 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@borod108 borod108 borod108 approved these changes

Assignees
No one assigned
Labels
bug hammer/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@d-m-u @miq-bot @simaishi @borod108