Fix disk_type attribute #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@borod108 looks like you'll need to adjust the specs |
We were calculating the disk_type based on the sparse property of the disk. This is incorrect, it should actually be calculated based on the format property. Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1598747
borod108
force-pushed
the
bug/1598747disk_type
branch
from
2a8f5e0
to
a0002db
Compare
|
Checked commit borod108@a0002db with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
Unrelated, but it is kind of sad how many duplicate parsers there are :( |
agrare
approved these changes
Aug 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were calculating the disk_type based on the sparse property of the
disk. This is incorrect, it should actually be calculated based on the
format property.
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1598747