Don't call Gem::Version.new() with a nil version #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the EMS api_version is nil don't call Gem::Version.new() to prevent the exception: ``` ArgumentError: Malformed version number string ``` This behavior changed in gem version 2.7.7 https://travis-ci.org/ManageIQ/manageiq-providers-ovirt/builds/380600591#L1969
|
Checked commit agrare@3f64cc1 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
bronaghs
reviewed
May 22, 2018
| @@ -14,7 +14,7 @@ def configure_cloud_init | |||
| return unless content = customization_template_content | |||
| with_provider_destination { |d| d.update_cloud_init!(content) } | |||
|
|
|||
| if Gem::Version.new(source.ext_management_system.api_version) >= Gem::Version.new("3.5.5.0") | |||
| if source.ext_management_system.api_version && Gem::Version.new(source.ext_management_system.api_version) >= Gem::Version.new("3.5.5.0") | |||
There was a problem hiding this comment.
might be worth assigning source.ext_management_system.api_version to a variable for readability, up to you though.
There was a problem hiding this comment.
👍 good point I'll push a followup to address this
simaishi
pushed a commit
that referenced
this pull request
May 22, 2018
Don't call Gem::Version.new() with a nil version (cherry picked from commit adf168a)
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the EMS api_version is nil don't call Gem::Version.new() to prevent
the exception:
This behavior changed in gem version 2.7.7
https://travis-ci.org/ManageIQ/manageiq-providers-ovirt/builds/380600591#L1969