Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update client to use renamed NetworkDiscovery #208

Merged
merged 1 commit into from
Feb 14, 2018
Merged

Update client to use renamed NetworkDiscovery #208

merged 1 commit into from
Feb 14, 2018

Conversation

jrafanie
Copy link
Member

@miq-bot
Copy link
Member

miq-bot commented Feb 13, 2018

Checked commit jrafanie@a1d0bd5 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. ⭐

@mwperina
Copy link

@masayag @borod108

@borod108 borod108 merged commit edfaaa8 into ManageIQ:master Feb 14, 2018
@borod108
Copy link
Contributor

@mwperina this is using the v3, but we talked about it not being urgent to change it to v4.

@jrafanie jrafanie deleted the rename_manageiq_network_to_network_discovery branch February 14, 2018 16:25
@gildub
Copy link
Contributor

gildub commented Feb 15, 2018

@jrafanie, the require needs update too.
#209 takes care of it.
Thanks

@gildub gildub mentioned this pull request Feb 15, 2018
Closed
14 tasks
jrafanie added a commit to jrafanie/manageiq-providers-ovirt that referenced this pull request Feb 15, 2018
@jrafanie
Add missing probe test
67a2df3 
We had a regression and tests didn't detect it:
ManageIQ#208
ManageIQ/manageiq#16994
jrafanie added a commit to jrafanie/manageiq-providers-ovirt that referenced this pull request Feb 15, 2018
@jrafanie
Add missing probe test
061f01b 
Note, Ovirt namespace exists in the client gem and also in the
ManageIQ::Providers namespace so we need to clarify which Ovirt we want,
namely, the ovirt gem's one.

We had a regression and tests didn't detect it:
ManageIQ#208
ManageIQ/manageiq#16994
@jrafanie jrafanie mentioned this pull request Feb 15, 2018
Merged
@agrare agrare added this to the Sprint 80 Ending Feb 26, 2018 milestone Feb 27, 2018
@gildub
Copy link
Contributor

gildub commented Mar 8, 2018

@miq-bot add_label gaprindashvili/yes

simaishi pushed a commit that referenced this pull request Mar 8, 2018
@borod108 @simaishi
Merge pull request #208 from jrafanie/rename_manageiq_network_to_netw…
ce03120 
…ork_discovery

Update client to use renamed NetworkDiscovery
(cherry picked from commit edfaaa8)

https://bugzilla.redhat.com/show_bug.cgi?id=1552665
@simaishi
Copy link
Contributor

simaishi commented Mar 8, 2018

Gaprindashvili backport details:

$ git log -1
commit ce03120e1560ad6bd49958f62d7e8c26fbee3ceb
Author: Boris Od <boris.od@gmail.com>
Date:   Wed Feb 14 17:33:12 2018 +0200

    Merge pull request #208 from jrafanie/rename_manageiq_network_to_network_discovery
    
    Update client to use renamed NetworkDiscovery
    (cherry picked from commit edfaaa8732f451e95414639538ee8a8afbf99a83)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1552665

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
gaprindashvili/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@jrafanie @miq-bot @mwperina @borod108 @gildub @simaishi @agrare