Provide missing events #180

pkliczewski · 2017-12-20T10:41:57Z

oVirt generates many kinds of events which are not defined on the provider side.
This PR provides missing events.

Fixes: https://bugzilla.redhat.com/1509004

oVirt generates many kinds of events which are not defined on the provider side. This PR provides missing events. Fixes: https://bugzilla.redhat.com/1509004

pkliczewski · 2017-12-20T10:42:16Z

@miq-bot assign @masayag

pkliczewski · 2017-12-20T10:42:25Z

@borod108 please review

pkliczewski · 2017-12-20T10:51:21Z

Bug 1509004 - rhv41 provider: event with event_type = "UNKNOWN" appears event_streams table when restart guest is called for vm

pkliczewski · 2017-12-20T10:52:05Z

@miq-bot add_labels gaprindashvili/yes

miq-bot · 2017-12-20T10:59:32Z

Checked commit pkliczewski@d437e42 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 159 offenses detected

app/models/manageiq/providers/redhat/infra_manager/event_fetcher.rb

❗ - Line 1000, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 1001, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 1002, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 1003, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 1004, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 1005, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 1006, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 1007, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 1008, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 1009, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 1010, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 1012, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 1013, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 1014, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 1015, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 1016, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 1017, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 1018, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 1019, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 1020, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 1021, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 1022, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 1023, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 1024, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 1025, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 1026, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 1027, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 1028, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 1029, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 1030, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 1031, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 1032, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 1033, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 1034, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 1035, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 1036, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 1037, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 1038, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 1039, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 1040, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 1041, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 1042, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 1043, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 1044, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 1045, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 1046, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 1047, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 1048, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 1049, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 1050, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 1051, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 1052, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 1053, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 1054, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 1055, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 1056, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 1057, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 1058, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 1059, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 1060, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 1061, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 1062, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 1063, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 1064, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 1065, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 1066, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 1067, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 1068, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 1069, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 1070, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 1071, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 1072, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 1073, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 1074, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 1075, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 1076, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 1077, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 1078, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 1079, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 1080, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 1081, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 1082, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 1083, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 1084, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 1085, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 1086, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 1087, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 1088, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 1089, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 1090, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 1091, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 1092, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 1093, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 1094, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 1095, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 1096, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 1097, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 938, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 939, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 940, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 941, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 942, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 943, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 944, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 945, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 946, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 947, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 948, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 949, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 950, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 951, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 952, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 953, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 954, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 955, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 956, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 957, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 958, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 959, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 960, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 961, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 962, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 963, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 964, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 965, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 966, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 967, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 968, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 969, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 970, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 971, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 972, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 973, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 974, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 975, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 976, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 977, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 978, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 979, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 980, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 981, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 982, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 983, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 984, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 985, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 986, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 987, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 988, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 989, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 990, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 991, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 992, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 993, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 994, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 995, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 996, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 997, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 998, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).
❗ - Line 999, Col 5 - Style/NumericLiterals - Separate every 3 digits in the integer portion of a number with underscores(_).

Provide missing events (cherry picked from commit ec2d09b) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1530742

simaishi · 2018-01-03T17:26:51Z

Gaprindashvili backport details:

$ git log -1
commit 4e1157af902f3b8af2962e6c51f6c91f8c2945fd
Author: Moti Asayag <masayag@redhat.com>
Date:   Wed Dec 20 13:12:22 2017 +0200

    Merge pull request #180 from pkliczewski/events
    
    Provide missing events
    (cherry picked from commit ec2d09b11d20a7d898a30f7a34496a30326a52e0)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1530742

Provide missing events

d437e42

oVirt generates many kinds of events which are not defined on the provider side. This PR provides missing events. Fixes: https://bugzilla.redhat.com/1509004

miq-bot assigned masayag Dec 20, 2017

miq-bot added the gaprindashvili/yes label Dec 20, 2017

borod108 approved these changes Dec 20, 2017

View reviewed changes

masayag approved these changes Dec 20, 2017

View reviewed changes

masayag merged commit ec2d09b into ManageIQ:master Dec 20, 2017

pkliczewski deleted the events branch December 20, 2017 11:34

agrare added this to the Sprint 76 Ending Jan 1, 2018 milestone Dec 20, 2017

simaishi pushed a commit that referenced this pull request Jan 3, 2018

Merge pull request #180 from pkliczewski/events

4e1157a

Provide missing events (cherry picked from commit ec2d09b) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1530742

simaishi added gaprindashvili/backported and removed gaprindashvili/yes labels Jan 3, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Provide missing events #180

Provide missing events #180

pkliczewski commented Dec 20, 2017

pkliczewski commented Dec 20, 2017

pkliczewski commented Dec 20, 2017

pkliczewski commented Dec 20, 2017

pkliczewski commented Dec 20, 2017

miq-bot commented Dec 20, 2017

simaishi commented Jan 3, 2018

Provide missing events #180

Provide missing events #180

Conversation

pkliczewski commented Dec 20, 2017

pkliczewski commented Dec 20, 2017

pkliczewski commented Dec 20, 2017

pkliczewski commented Dec 20, 2017

pkliczewski commented Dec 20, 2017

miq-bot commented Dec 20, 2017

simaishi commented Jan 3, 2018