Targeting host fails #171
Targeting host fails #171
Conversation
|
@miq-bot add_labels gaprindashvili/yes |
|
@borod108 please review |
| end | ||
|
|
||
| def self.vm_location(dc, vm_ref) | ||
| def self.vm_location(hash, dc, vm_ref) |
There was a problem hiding this comment.
I think this should either have another name or we should add the "return nil if vm_ref.nil?" without the adding the hash as a parameter and clear the vm_location key from the hash in the calling function in case its value is nil.
But to me this name does not correspond to a method that returns a hash with a lot of other attributes in addition to location, and some times does not return any location at all.
There was a problem hiding this comment.
I will update the name. Please note that we do not want to have nil value for this key so returning nil is not an option.
When ever a host is targeted event parsing fail since it is not possible to build `vm_location`. We make sure that it is not calculated when targeting a host. Bug-Url: https://bugzilla.redhat.com/1520513
|
Checked commit pkliczewski@8458734 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0 |
Targeting host fails (cherry picked from commit 66d9e37) https://bugzilla.redhat.com/show_bug.cgi?id=1524731
|
Gaprindashvili backport details: |
When ever a host is targeted event parsing fail since it is not possible to
build
vm_location. We make sure that it is not calculated when targeting a host.Bug-Url:
https://bugzilla.redhat.com/1520513