Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagate user validation errors #104

Merged
merged 1 commit into from
Oct 9, 2017

Conversation

pkliczewski
Copy link
Contributor

We need to make sure that any errors during ovirt credentials validation are properly
propagated to the user.

We need to make sure that any errors during ovirt credentials validation are properly
propagated to the user.
@miq-bot
Copy link
Member

miq-bot commented Oct 9, 2017

Checked commit pkliczewski@7f9e40e with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks fine. 👍

@pkliczewski
Copy link
Contributor Author

@masayag @jhernand please review

@pkliczewski
Copy link
Contributor Author

Copy link
Member

@agrare agrare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@agrare agrare merged commit 7f9e40e into ManageIQ:master Oct 9, 2017
agrare added a commit that referenced this pull request Oct 9, 2017
@agrare agrare added the bug label Oct 9, 2017
@agrare agrare added this to the Sprint 71 Ending Oct 16, 2017 milestone Oct 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants