Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix adapted_grid failure #4464

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Fix adapted_grid failure #4464

wants to merge 2 commits into from

Conversation

ffreyer
Copy link
Collaborator

@ffreyer ffreyer commented Oct 9, 2024

Description

With Julia 1.11 the "scatter inputs" refimg now fails because rand(MersenneTwister(1337)) which is used in PlotUtils.adapted_grid() produces different results.

This pr aims to fix the Problem by allowing StableRNG to be passed.

Some Notes:

  • passing the rng through used_attributes may not be a very stable solution, and it requires explicit passing in refimg tests
  • setting the rng as a global ref in Makie and changing it for CI would mean that two plots with same inputs would generate different data as the rng advances
    • calling seed! to reset the rng would solve that issue, but we can't use Random.default_rng() in that case (we mustn't reset the global rng)

Type of change

Delete options that do not apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • Added an entry in CHANGELOG.md (for new features and breaking changes)
  • Added or changed relevant sections in the documentation
  • Added unit tests for new algorithms, conversion methods, etc.
  • Added reference image tests for new plotting functions, recipes, visual options, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Work in progress
Development

Successfully merging this pull request may close these issues.

1 participant