Adjust layout of ReferenceUpdater #4398
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This changes the layout of the page generated by ReferenceUpdater to be a table. The format is:
without having the column and row labels explicitly. If a refimg does not exist for a given backend, the cell is left blank. These change are meant to make it easier to compare backend to backend and also bring cross-backend failures closer together. (E.g. if something is changed in Makie requiring refimg X to be updated for all backends, the related failures are now grouped together.)
Refimgs now resize based on the table column width (up to 100% of their size). This is sort of a consequence of a layout, but I think it's also generally makes refimages easier to check.
If a refimg causes CI to fail (score > 0.05) the background becomes red, otherwise yellow (> 0.001) or light gray (else). This should make it easier to spot which test in a row is failing and it also differentiates the page/cell background from the figure background.
Sorting is now based on
maximum(row_scores)
to move all the worst scores to the top of the page.Type of change