Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Axis case #3046

Merged
merged 1 commit into from
Jul 6, 2023
Merged

Change Axis case #3046

merged 1 commit into from
Jul 6, 2023

Conversation

pepijndevos
Copy link
Contributor

Description

I'm not 100% sure if this is correct but there seems to be a mismatch between the default theme and other themes.
Or are these actually completely distinct and unrelated things?

julia> println(keys(Makie.CURRENT_DEFAULT_THEME))
[:limits, :colormap, :visible, :axis, :fonts, :rowgap, :markerstrokewidth, :patchstrokecolor, :linecolor, :markersize, :camera, :linestyle, :font, :axis_type, :ambient, :lightposition, :figure_padding, :markerstrokecolor, :patchcolor, :RPRMakie, :legend, :axis3d, :textcolor, :resolution, :marker, :padding, :colgap, :SSAO, :CairoMakie, :palette, :backgroundcolor, :markercolor, :fontsize, :patchstrokewidth, :linewidth, :inspectable, :GLMakie, :WGLMakie]

julia> println(keys(theme_black()))
[:backgroundcolor, :Axis, :textcolor, :Axis3, :Legend, :Colorbar, :linecolor]

Type of change

Delete options that do not apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • Added an entry in NEWS.md (for new features and breaking changes)
  • Added or changed relevant sections in the documentation
  • Added unit tests for new algorithms, conversion methods, etc.
  • Added reference image tests for new plotting functions, recipes, visual options, etc.

@SimonDanisch SimonDanisch merged commit 83fc003 into MakieOrg:master Jul 6, 2023
13 checks passed
@SimonDanisch
Copy link
Member

Thanks!

@jkrumbiegel
Copy link
Member

these might have just been deleted I think, they were remnants of the old Scene axis attributes

@SimonDanisch
Copy link
Member

But, we still use them right? I think it's not needed to be in there since blocks handle the case, but I think having a placeholder in the theme is a good thing?

@jkrumbiegel
Copy link
Member

yeah it kind of just does nothing :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants