Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix WGLMakie JS popup #2976

Merged
merged 2 commits into from
May 26, 2023
Merged

fix WGLMakie JS popup #2976

merged 2 commits into from
May 26, 2023

Conversation

SimonDanisch
Copy link
Member

No description provided.

@MakieBot
Copy link
Collaborator

MakieBot commented May 23, 2023

Compile Times benchmark

Note, that these numbers may fluctuate on the CI servers, so take them with a grain of salt. All benchmark results are based on the mean time and negative percent mean faster than the base branch. Note, that GLMakie + WGLMakie run on an emulated GPU, so the runtime benchmark is much slower. Results are from running:

using_time = @ctime using Backend
# Compile time
create_time = @ctime fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @ctime Makie.colorbuffer(display(fig))
# Runtime
create_time = @benchmark fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @benchmark Makie.colorbuffer(display(fig))
using create display create display
GLMakie 11.17s (10.97, 11.38) 0.17+- 1.23s (1.20, 1.26) 0.02+- 920.79ms (885.64, 969.13) 29.28+- 11.70ms (11.54, 12.12) 0.21+- 102.56ms (101.52, 104.31) 1.11+-
master 11.16s (11.03, 11.27) 0.09+- 1.22s (1.20, 1.24) 0.02+- 907.96ms (896.27, 929.54) 11.42+- 11.68ms (11.45, 12.02) 0.19+- 102.44ms (102.04, 103.28) 0.42+-
evaluation +0.05%, 0.01s invariant (0.04d, 0.94p, 0.13std) +0.75%, 0.01s invariant (0.52d, 0.35p, 0.02std) +1.39%, 12.83ms invariant (0.58d, 0.31p, 20.35std) +0.20%, 0.02ms invariant (0.11d, 0.83p, 0.20std) +0.11%, 0.11ms invariant (0.14d, 0.80p, 0.77std)
CairoMakie 9.74s (9.66, 9.87) 0.07+- 1.36s (1.34, 1.38) 0.01+- 321.62ms (318.36, 329.31) 3.95+- 11.64ms (11.54, 11.69) 0.06+- 6.57ms (6.51, 6.75) 0.08+-
master 9.78s (9.73, 9.84) 0.04+- 1.33s (1.30, 1.34) 0.02+- 354.06ms (349.39, 360.32) 3.84+- 11.63ms (11.55, 11.69) 0.05+- 6.56ms (6.47, 6.67) 0.07+-
evaluation -0.48%, -0.05s invariant (-0.84d, 0.15p, 0.05std) +2.49%, 0.03s slower X (2.38d, 0.00p, 0.01std) -10.08%, -32.43ms faster✅ (-8.33d, 0.00p, 3.89std) +0.08%, 0.01ms invariant (0.19d, 0.73p, 0.05std) +0.18%, 0.01ms invariant (0.15d, 0.78p, 0.08std)
WGLMakie 11.90s (11.51, 12.18) 0.22+- 1.56s (1.51, 1.67) 0.05+- 13.60s (13.36, 13.81) 0.14+- 15.49ms (14.71, 15.81) 0.41+- 1.08s (1.00, 1.24) 0.10+-
master 11.95s (11.78, 12.12) 0.13+- 1.49s (1.45, 1.52) 0.02+- 13.66s (13.41, 14.24) 0.28+- 15.85ms (14.75, 17.00) 0.82+- 1.10s (0.99, 1.30) 0.12+-
evaluation -0.36%, -0.04s invariant (-0.24d, 0.66p, 0.17std) +4.59%, 0.07s slower X (1.80d, 0.01p, 0.04std) -0.48%, -0.07s invariant (-0.29d, 0.59p, 0.21std) -2.32%, -0.36ms invariant (-0.56d, 0.33p, 0.61std) -2.31%, -0.02s invariant (-0.22d, 0.68p, 0.11std)

@SimonDanisch SimonDanisch merged commit ffc31a0 into master May 26, 2023
@SimonDanisch SimonDanisch deleted the sd/fix-popup branch May 26, 2023 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants