Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit tests back to pipeline & improve VSCode integration #581

Merged
merged 49 commits into from
May 13, 2024
Merged

Add unit tests back to pipeline & improve VSCode integration #581

merged 49 commits into from
May 13, 2024

Commits on Dec 18, 2023

  1. Add Python script to run Rspec tests in docker container 

    This builds on the Ruby Test Explorer VSCode extension.
See my comment here: connorshea/vscode-ruby-test-adapter#30 (comment)
    @Splines
    Splines committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    bf30e9f View commit details
    Browse the repository at this point in the history

Commits on Jan 7, 2024

  1. Merge branch 'mampf-next' into pipeline/tests

    @Splines
    Splines committed Jan 7, 2024
    Configuration menu
    Copy the full SHA
    c3541de View commit details
    Browse the repository at this point in the history

  2. Add Ruby Test explorer settings to settings.json

    @Splines
    Splines committed Jan 7, 2024
    Configuration menu
    Copy the full SHA
    103789d View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2024

  1. Rename run_cypress_tests to test & use buildx 

    buildx is used for faster builds
we also set up ghcr to use docker layer caching for hopefully even
faster build times
    @Splines
    Splines committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    68c0122 View commit details
    Browse the repository at this point in the history

  2. Fix paths to files and rename to Testing

    @Splines
    Splines committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    63544f8 View commit details
    Browse the repository at this point in the history

  3. Use lowercase github org name

    @Splines
    Splines committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    b311ca1 View commit details
    Browse the repository at this point in the history

  4. Use GitHub Rspec formatter

    @Splines
    Splines committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    1d4e9af View commit details
    Browse the repository at this point in the history

  5. Clean up tests.yml & add comment with useful links

    @Splines
    Splines committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    1eb3cf7 View commit details
    Browse the repository at this point in the history

  6. Delete unnecessary dotfiles

    @Splines
    Splines committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    3e51aa1 View commit details
    Browse the repository at this point in the history

  7. Fix path due to renaming of run_cypress_tests to test

    @Splines
    Splines committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    84d6a45 View commit details
    Browse the repository at this point in the history

  8. Add more comments to tests.yml

    @Splines
    Splines committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    1d5c757 View commit details
    Browse the repository at this point in the history

  9. Don't deal with cypress_runner here

    @Splines
    Splines committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    229dcdb View commit details
    Browse the repository at this point in the history

  10. Only cache real build targets 

    Other layers will get cached anyways as they are external images.
    @Splines
    Splines committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    840c63d View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2024

  1. Merge branch 'dev' into pipeline/tests

    @Splines
    Splines committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    d11dc2d View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2024

  1. Merge branch 'dev' into pipeline/tests

    @Splines
    Splines committed Apr 27, 2024
    Configuration menu
    Copy the full SHA
    eb0a4b7 View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2024

  1. Source dummy docker env variables

    @Splines
    Splines committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    69e12a9 View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2024

  1. Merge branch 'dev' into pipeline/tests

    @Splines
    Splines committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    faa51e8 View commit details
    Browse the repository at this point in the history

  2. Add missing `require "rails_helper" statement

    @Splines
    Splines committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    4c18e8c View commit details
    Browse the repository at this point in the history

  3. Move comment to correct place in test

    @Splines
    Splines committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    b7f103c View commit details
    Browse the repository at this point in the history

  4. Fix missing = in workflow file

    @Splines
    Splines committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    38440de View commit details
    Browse the repository at this point in the history

  5. Source docker-dummy.env in docker test environment

    @Splines
    Splines committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    acd162f View commit details
    Browse the repository at this point in the history

  6. Don't source dummy docker env & add missing env variables 

    We just add the missing env variables to the docker-compose.yml config
for the test setup.
    @Splines
    Splines committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    16ca7d5 View commit details
    Browse the repository at this point in the history

  7. Disable "can destroy users" test

    @Splines
    Splines committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    439c004 View commit details
    Browse the repository at this point in the history

  8. Copy missing app folder in Dockerfile (test setup)

    @Splines
    Splines committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    c9c6c54 View commit details
    Browse the repository at this point in the history

  9. Remove creation of test database in workflow

    @Splines
    Splines committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    aa9a27e View commit details
    Browse the repository at this point in the history

Commits on May 1, 2024

  1. Precompile webpacker assets into docker test image

    @Splines
    Splines committed May 1, 2024
    Configuration menu
    Copy the full SHA
    182d5cf View commit details
    Browse the repository at this point in the history

  2. Fix failing media search tests (first iteration)

    @Splines
    Splines committed May 1, 2024
    Configuration menu
    Copy the full SHA
    ce040aa View commit details
    Browse the repository at this point in the history

  3. Fix media search tests 

    These changes are necessary due to #593.
    @Splines
    Splines committed May 1, 2024
    Configuration menu
    Copy the full SHA
    5e54d13 View commit details
    Browse the repository at this point in the history

  4. Upgrade Node.js dev dependencies

    @Splines
    Splines committed May 1, 2024
    Configuration menu
    Copy the full SHA
    710146b View commit details
    Browse the repository at this point in the history

  5. Merge branch 'deps/upgrade-dev-yarn-packages' into pipeline/tests

    @Splines
    Splines committed May 1, 2024
    Configuration menu
    Copy the full SHA
    92e5b74 View commit details
    Browse the repository at this point in the history

  6. Fix wrong ESLint semicolon-key value

    @Splines
    Splines committed May 1, 2024
    Configuration menu
    Copy the full SHA
    5552d39 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'deps/upgrade-dev-yarn-packages' into pipeline/tests

    @Splines
    Splines committed May 1, 2024
    Configuration menu
    Copy the full SHA
    9d2be2c View commit details
    Browse the repository at this point in the history

  8. Remove pending test

    @Splines
    Splines committed May 1, 2024
    Configuration menu
    Copy the full SHA
    5d7c131 View commit details
    Browse the repository at this point in the history

  9. Freeze string assigned to constant (rubocop)

    @Splines
    Splines committed May 1, 2024
    Configuration menu
    Copy the full SHA
    a7e116c View commit details
    Browse the repository at this point in the history

  10. Try to use delete_all instead of destroy_all 

    This may be a fix for the issue `Can't modify frozen hash` we get in the
pipeline during the unit tests.
    @Splines
    Splines committed May 1, 2024
    Configuration menu
    Copy the full SHA
    58b28c6 View commit details
    Browse the repository at this point in the history

  11. Don't delete Medium table as DatabaseClenaer takes care of it

    @Splines
    Splines committed May 1, 2024
    Configuration menu
    Copy the full SHA
    1983c6f View commit details
    Browse the repository at this point in the history

  12. Improve database cleaner config according to docs

    @Splines
    Splines committed May 1, 2024
    Configuration menu
    Copy the full SHA
    f8d1872 View commit details
    Browse the repository at this point in the history

Commits on May 7, 2024

  1. Only rely on active record database cleaner gem 

    See the gem setup here:
https://www.rubydoc.info/github/DatabaseCleaner/database_cleaner#gem-setup
    @Splines
    Splines committed May 7, 2024
    Configuration menu
    Copy the full SHA
    415619c View commit details
    Browse the repository at this point in the history

  2. Use before() & after() instead of around() in DB cleaner

    @Splines
    Splines committed May 7, 2024
    Configuration menu
    Copy the full SHA
    cf08e5b View commit details
    Browse the repository at this point in the history

  3. Explicitly require database_cleaner gem

    @Splines
    Splines committed May 7, 2024
    Configuration menu
    Copy the full SHA
    4e7e995 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'dev' into pipeline/tests

    @Splines
    Splines committed May 7, 2024
    Configuration menu
    Copy the full SHA
    4c32260 View commit details
    Browse the repository at this point in the history

  5. Use append_after() instead of append() 

    See here: https://www.rubydoc.info/github/DatabaseCleaner/database_cleaner#rspec-with-capybara-example
    @Splines
    Splines committed May 7, 2024
    Configuration menu
    Copy the full SHA
    0b8ecac View commit details
    Browse the repository at this point in the history

  6. Change directory to test folder

    @Splines
    Splines committed May 7, 2024
    Configuration menu
    Copy the full SHA
    ebbe53d View commit details
    Browse the repository at this point in the history

  7. Revert "Change directory to test folder" 

    This reverts commit ebbe53d.
    @Splines
    Splines committed May 7, 2024
    Configuration menu
    Copy the full SHA
    0ef6766 View commit details
    Browse the repository at this point in the history

  8. Try to use transactional fixtures

    @Splines
    Splines committed May 7, 2024
    Configuration menu
    Copy the full SHA
    84646cc View commit details
    Browse the repository at this point in the history

  9. Use database cleaner, omit before :all (instead use before :each)

    @Splines
    Splines committed May 7, 2024
    Configuration menu
    Copy the full SHA
    b509099 View commit details
    Browse the repository at this point in the history

  10. Pass token to Codecov test workflow

    @Splines
    Splines committed May 7, 2024
    Configuration menu
    Copy the full SHA
    1838386 View commit details
    Browse the repository at this point in the history

  11. Ignore test files in Codecov report

    @Splines
    Splines committed May 7, 2024
    Configuration menu
    Copy the full SHA
    8cd49cc View commit details
    Browse the repository at this point in the history

  12. Use testing GitHub environment for CI/CD

    @Splines
    Splines committed May 7, 2024
    Configuration menu
    Copy the full SHA
    d86b4ae View commit details
    Browse the repository at this point in the history