-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Container Support #30
Labels
bug
Something isn't working
Comments
@hennevogel, I fixed this by copying this file to docker container but it makes the plugin work only partially. You can run tests once but not one single of them. There is some other issue. I would like to have this feature too without even speciying any commands. Like [x] Docker. |
I got this working by configuring test explorer to use a shell script as my rspec command. Contents of rspec-inside-docker.sh
|
This comment was marked as outdated.
This comment was marked as outdated.
Splines
added a commit
to MaMpf-HD/mampf
that referenced
this issue
Dec 18, 2023
This builds on the Ruby Test Explorer VSCode extension. See my comment here: connorshea/vscode-ruby-test-adapter#30 (comment)
7 tasks
Splines
added a commit
to MaMpf-HD/mampf
that referenced
this issue
May 13, 2024
* Add Python script to run Rspec tests in docker container This builds on the Ruby Test Explorer VSCode extension. See my comment here: connorshea/vscode-ruby-test-adapter#30 (comment) * Add Ruby Test explorer settings to `settings.json` * Rename `run_cypress_tests` to `test` & use buildx buildx is used for faster builds we also set up ghcr to use docker layer caching for hopefully even faster build times * Fix paths to files and rename to `Testing` * Use lowercase github org name * Use GitHub Rspec formatter * Clean up tests.yml & add comment with useful links * Delete unnecessary dotfiles * Fix path due to renaming of `run_cypress_tests` to `test` * Add more comments to tests.yml * Don't deal with cypress_runner here * Only cache real build targets Other layers will get cached anyways as they are external images. * Source dummy docker env variables * Add missing `require "rails_helper" statement * Move comment to correct place in test * Fix missing `=` in workflow file * Source docker-dummy.env in docker test environment * Don't source dummy docker env & add missing env variables We just add the missing env variables to the docker-compose.yml config for the test setup. * Disable "can destroy users" test * Copy missing app folder in Dockerfile (test setup) * Remove creation of test database in workflow * Precompile webpacker assets into docker test image * Fix failing media search tests (first iteration) * Fix media search tests These changes are necessary due to #593. * Upgrade Node.js dev dependencies * Fix wrong ESLint semicolon-key value * Remove pending test * Freeze string assigned to constant (rubocop) * Try to use `delete_all` instead of `destroy_all` This may be a fix for the issue `Can't modify frozen hash` we get in the pipeline during the unit tests. * Don't delete Medium table as DatabaseClenaer takes care of it * Improve database cleaner config according to docs * Only rely on active record database cleaner gem See the gem setup here: https://www.rubydoc.info/github/DatabaseCleaner/database_cleaner#gem-setup * Use before() & after() instead of around() in DB cleaner * Explicitly require database_cleaner gem * Use append_after() instead of append() See here: https://www.rubydoc.info/github/DatabaseCleaner/database_cleaner#rspec-with-capybara-example * Change directory to test folder * Revert "Change directory to test folder" This reverts commit ebbe53d. * Try to use transactional fixtures * Use database cleaner, omit before :all (instead use before :each) * Pass token to Codecov test workflow * Ignore test files in Codecov report * Use testing GitHub environment for CI/CD
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Your environment
vscode-ruby-test-adapter
version: 0.6.0Expected behavior
My development environment uses containers so I set
rubyTestExplorer.rspecCommand
to something likedocker-compose run --rm frontend bundle exec rspec
and thevscode-ruby-test-adapter
worksActual behavior
There are a couple of problems with this:
CustomFormatter
needs to get into my container. This can be work arounded by makinggetCustomFormatterLocation
configurable and putting the file into the workspace somehow (like copy it to.vscode/custom_formatter.rb
)rubyTestExplorer.*Directory
somehow needs to be not relative to the workspace.The text was updated successfully, but these errors were encountered: