Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding data preprocessing code for ITQM 2023 paper "Generation of Radiology Findings in Chest X-Ray by Leveraging Collaborative Knowledge" #1745

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

DanuManuela
Copy link

This pull request is to contribute code associated with the ITQM 2023 paper "Generation of Radiology Findings in Chest X-Ray by Leveraging Collaborative Knowledge". The experiments conducted in this paper were based on the publicly available MIMIC-CXR dataset.

The code we want to publish is the one utilized for preparing the data for the experiments.

The paper is available at this link.

…diology Findings in Chest X-Ray by Leveraging Collaborative Knowledge
@tompollard
Copy link
Member

Thanks for the contribution! This pull request makes me realise that we don't have a good way of managing the code that underpins published papers.

I'm wondering whether we should either:

  1. Have a papers subfolder in this repository, along with an index of papers (with link, citation, etc) in a markdown document.
  2. Instead, ask for the code for papers to be added to a separate repository, and just include an index of papers in this repository.

I would be interested in hearing your thoughts on this. @DanuManuela @alistairewj @bemoody

@DanuManuela DanuManuela closed this May 2, 2024
@DanuManuela DanuManuela reopened this May 2, 2024
@DanuManuela
Copy link
Author

I am more inclined towards the first option. It just seems easier to have a dedicated folder for papers within the repository, thus keeping all the relevant materials in one place. However, I'm totally open to option two as well.

@tompollard
Copy link
Member

tompollard commented May 2, 2024

Thanks @DanuManuela, I basically agree that it would be nice to have everything in one place, but when I think about this a little more my preference is option 2 because:

  • Even if we want to have everything in one place, most people will probably end up sharing elsewhere, so this goal is difficult to achieve.
  • If we do have everything in one place (i.e. this repo), we are going to struggle with maintenance. People will start opening issues and bug fixes to the code. We (our lab at MIT) probably aren't the right people to address them.

Hopefully Benjamin and Alistair can add their thoughts (plus anyone who is interested!).

@alistairewj
Copy link
Member

Yeah this is really great and thanks for contributing! With that said, I will add that I also think you should make your own repo for this. We can still include a reference here to give your work visibility. Having your own repo will help keep issues related to your work in the separate repo (so you don't get overloaded by mimic code issues, unless you choose to be!), allow citations to properly credit you, and in general it removes the need for us to standardize contributions, which would be very hard indeed. These thoughts are in addition to the ones mentioned above.

One thing that could be nice is a semi-standardized table for inclusion in your README that makes it easier to understand the code. Just simple things like SQL dialect, etc, could be useful.

So the suggested plan would be;

(1) create your own repository with the code
(2) (optional) mint a doi with Zenodo
(3) contribute a link to that repo / DOI in an index file here (n.b. I had dreams of doing this with MIMIC-CXR and an awesome MIMIC-CXR markdown file but to date these dreams have not materialized).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants