Skip to content

Commit

Permalink
0.5.0r
Browse files Browse the repository at this point in the history
  • Loading branch information
tsrobinson committed Aug 23, 2023
1 parent 8c1aedf commit a89908f
Show file tree
Hide file tree
Showing 3 changed files with 21 additions and 14 deletions.
8 changes: 4 additions & 4 deletions .Rhistory
Original file line number Diff line number Diff line change
@@ -1,7 +1,3 @@
} else {
return(TRUE)
}
}
#' Check whether all Python packages are available
#'
#' Checks if each Python dependency is available.
Expand Down Expand Up @@ -510,3 +506,7 @@ check_rhub()
install.packages("V8")
check_win_devel()
check_win_release()
library(devtools)
check()
build()
devtools::release()
6 changes: 3 additions & 3 deletions CRAN-SUBMISSION
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
Version: 0.4.2
Date: 2023-06-13 21:47:39 UTC
SHA: dbb37fc9fbd2b8967539138aa9e27ae33c270705
Version: 0.5.0
Date: 2023-08-22 08:44:06 UTC
SHA: 821d0e8daed9c00948656d8618e5525fbe9ec071
21 changes: 14 additions & 7 deletions cran-comments.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
## v0.5.0

This is a re-submission:

* We have fixed the broken URL
* We have amended our package start-up messages to address the previous note

In this version, we have:

* Added an automatic configuration for interfacing with Python, to ease the setup for users
Expand All @@ -9,6 +14,14 @@ In this version, we have:
* Updated existing vignettes
* Updated accompanying YAML file to work on all major operating systems (including Apple silicon hardware)

### Note on startup messages

The previous note referred to our use of messages in `.onLoad()`, specifically that we use 'readLine' to ask users whether they would like the package to auto-configure Python requirements. All other messages were already wrapped in `packageStartupMessage`.

The startup messages are designed to cater to both novice and experienced users. For non-power users they provide essential information without being redundant. For power users they are essentially bypassed. Moreover, this approach differentiates between interactive and non-interactive sessions, preventing sessions hanging when run on display-less servers.

The only write-out operation is a simple 'y/n' text file, which is crucial for rMIDAS package’s functionality.

## Test environments
* Local OS X install, R 4.3.0
* Fedora Linux, R-devel, clang, gfortran
Expand All @@ -18,13 +31,7 @@ In this version, we have:

## R CMD check results

There were no errors, or warnings, and 1 note.

The note refers to our use of messages in `.onLoad()`, specifically that we use 'readLine' to ask users whether they would like the package to auto-configure Python requirements. All other messages are wrapped in 'packageStartupMessage'.

The startup messages are designed to cater to both novice and experienced users. For non-power users they provide essential information without being redundant. For power users they are essentially bypassed. Moreover, this approach differentiates between interactive and non-interactive sessions, preventing sessions hanging when run on display-less servers.

The only write-out operation is a simple 'y/n' text file, which is crucial for rMIDAS package’s functionality.
There were no errors, warnings, or notes.

## Downstream dependencies
There are no downstream dependencies currently.

0 comments on commit a89908f

Please sign in to comment.