-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Example CI + Fixes to some broken example! #525
base: master
Are you sure you want to change the base?
Conversation
I'm not exactly sure whats wrong with the test suite, but I think if I add the --generate flag they should be okay. Do we want the test suite to even test for examples because that would add another 30 minutes or more to them. Also I need to remove the -r flag from the example suites but it looks like it worked fine. |
@okBrian we can add this as a separate GitHub workflow (Examples-test.yml, Example Smoke Test). |
the |
@okBrian It's important that these cases run and produce output that isn't nonsense. So you can run the "example suite" with If |
If you specify Whether we should or should not use the |
…1 on examples, fixed m_patches typo. todo: fix 1D bubble cases
toolchain/mfc/test/test.py
Outdated
@@ -180,7 +181,7 @@ def _handle_case(case: TestCase, devices: typing.Set[int]): | |||
raise MFCException(f"Test {case}: {msg}") | |||
|
|||
if ARG("test_all"): | |||
case.delete_output() | |||
# case.delete_output() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
might want to put this back?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It breaks the 1D bubble cases. Not sure why maybe its deleting the D folder I'm creating.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perhaps associated with current bug in CI that if it has to 'retry' a simulation, it will try to create a directory that already exists
I am expecting the code to not work with --no-mpi so thats another thing to debug... I think everything with mpi should pass hopefully. |
this won't work on Phoenix until @henryleberre merges #581 and you pull in the module changes for Phoenix (we moved to RHEL9 nodes). |
Oh my bad I thought they were done based on the most recent commit. |
Well, they should be working but there's an issue with @sbryngelson's Python installation. I'm pretty sure it's because he deleted bits from his |
I actually never deleted anything in my |
You can see that this works by looking here: https://github.com/MFlowCode/MFC/actions/runs/10498547818/job/29083688602 @henryleberre also opened this empty PR to test things #586 |
Hey is GT Phoenix fully migrated or should I keep waiting? |
It's not working yet, though the Docker should be? |
@okBrian It should be working now ™. You should just need to rebase on upstream. |
@okBrian you can sync with master now, it should work |
Phoenix is down so none of the Phoenix CI will pass for now... will reboot those when they come back online |
@okBrian Phoenix CI is back online, but now you will need to rebase as @henryleberre made a change for Frontier CI as well as the packer golden files. |
Also, @okBrian you need to regenerate the golden files for your new cases. Alternatively, I can run a script for you that strips the |
@okBrian phoenix runners are back up, though this branch needs to be synced with master |
Description
Added New Example CI, - Average runtime - 30 minutes
Why MacOS runner?
From my initial testing its much faster than the ubuntu images. Some examples ran over two times faster on the MacOS runner
Why 15625, (125, 125), or (25, 25, 25) for cell boundaries?
Some 3D examples break if m < 25, and this seems like a good spot to put examples so they don't take too long
Fixes #474
Type of change
Scope
How Has This Been Tested?
Test Configuration:
gcc 14, Ubuntu 22,04.4 LTS
Github Action Macos Runner
Checklist
./mfc.sh format
before committing my code