build: Fix libcaesium lookup on Linux #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
huh, I tested building it with libcaesium 0.16.4 and it was built just fine. I guess the problem (based on the error log) is that the older version of libcaesium require mozjpeg-sys version 1.1 and the newer one needs 2.2 which works just fine? |
|
Yes the pipeline fails because of a removed dependency of libcaesium. I will update libcaesium dependency on this repo so the pipeline does not fail and rerun the checks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure why this commit df6f440 comment out the line to find libcaesium in CMakeList.txt but if it is intentional, we could try to find a workaround