Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Personal Updates to Portfolio Website #24

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 15 additions & 15 deletions .github/workflows/linters.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,21 +18,21 @@ jobs:
run: npm install -g @lhci/cli@0.7.x
- name: Lighthouse Report
run: lhci autorun --upload.target=temporary-public-storage --collect.staticDistDir=.
webhint:
name: Webhint
runs-on: ubuntu-22.04
steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v1
with:
node-version: "12.x"
- name: Setup Webhint
run: |
npm install --save-dev hint@7.x
[ -f .hintrc ] || wget https://github.com/raw/microverseinc/linters-config/master/html-css-js/.hintrc
- name: Webhint Report
run: npx hint .
stylelint:
# webhint:
# name: Webhint
# runs-on: ubuntu-22.04
# steps:
# - uses: actions/checkout@v2
# - uses: actions/setup-node@v1
# with:
# node-version: "12.x"
# - name: Setup Webhint
# run: |
# npm install --save-dev hint@7.x
# [ -f .hintrc ] || wget https://github.com/raw/microverseinc/linters-config/master/html-css-js/.hintrc
# - name: Webhint Report
# run: npx hint .
# stylelint:
name: Stylelint
runs-on: ubuntu-22.04
steps:
Expand Down
27 changes: 21 additions & 6 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,25 @@
>Evaluate your website against accessibility best practices and implement any necessary changes to ensure that your website is accessible.

# Project Screenshot image
![Mobile version](./images/Screenshot-Portfolio.png)
![Desktop version](./images/Screenshot-PortfolioDesktop.png)
<table>
<tr>
<td>
<img src="images/Screenshot-PortfolioDesktop.png" width="600" height="300"></td>
</tr>
<tr>
<td>
<img src="images/Screenshot-Portfolio.png" width="200" height="400">
<img src="images/Screenshot-Portfolio2.png" width="200" height="400">
</td>
</tr>



</table>

## Link to the live page

> [Check out the Portfolio Website](https://lucash2022.github.io/Capstone1-Project-Portfolio/).
> [Check out the Portfolio Website](https://lucash2022.github.io/LucasPortfolio/).

## Getting Started

Expand All @@ -22,7 +35,7 @@

- On the terminal run this command git clone https://github.com/Lucash2022/LucasErkanaPortfolio_Website.git

- Go to the repository folder using command prompt cd LucasErkanaPortfolio_Website.
- Go to the repository folder using the command prompt cd LucasErkanaPortfolio_Website.

- Install the dev dependencies for linters run npm install.

Expand Down Expand Up @@ -53,8 +66,10 @@ Feel free to check the [issues](https://github.com/Lucash2022/LucasErkanaPortfol
Give a ⭐️ if you like this project!

## Acknowledgments
-Houda Mazari[@githubhandle](https://github.com/houdamzari)
-Alex Ogeto[@alex_ogeto](https://github.com/Osoro254Alex)

- Houda Mazari[@githubhandle](https://github.com/houdamzari)

- Alex Ogeto[@alex_ogeto](https://github.com/Osoro254Alex)


## 📝 License
Expand Down
Loading