-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Add support for user-mounted widgets #761
Conversation
✅ Deploy Preview for dashy-dev ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Changes preview: |
This looks great. We could modify the Maybe that means you could mount something pre-compiled in I think technically you don't need to define This might address 2 out of 3 limitations. Maybe 3 if its possible to precompile and mount that instead. |
I experimented with the vue bundles a little bit trying to figure out the precompiled route. I tried exporting as wc and a lib. Because of the optimizations and bundle chunking I don't think it would be easy to inject that into the page, not without being too hacky. I am not sure https://github.com/FranckFreiburger/vue3-sfc-loader could work for more complex components that have dependencies. I am thinking the build is probably unavoidable at this point with this approach. The upside is everything is minified and chunked as expected which will probably come in handy with multi-page support and dynamically loading only the chunks that are necessary.
|
This PR is stale because it has been open 6 weeks with no activity. Either remove the stale label or comment below with a short update, otherwise this PR will be closed in 5 days. |
@Lissy93 Would you be able to share some insight as to why this was closed? No longer interested in the feature, pursuing a different implementation, etc? Thanks! |
This PR is stale because it has been open 6 weeks with no activity. Either remove the stale label or comment below with a short update, otherwise this PR will be closed in 5 days. |
Category: Feature
Overview
Just an idea...
This PR would allow a user to mount a custom widget.
Usage:
Create a widget, and mount it into the Widgets directory.
Sub-folders are allowd, so can be mounted as directory.
Then list that widget under
appConfig.customWidgets
, like:Then use it like normal:
Limitations:
Todo:
Issue Number this comment
New Vars
// TODO
Screenshot N/A
Code Quality Checklist (Please complete)