[FEATURE] Adds ability for config file to be written to directly from the UI #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…some improvments though.
…revent the user from writing changes to the conf file from the UI
…ature_write-config-to-file-system
…ript Ensures environment is correctly set to production, and sets build-and-start script to now recompoile when conf.yml is updated
…config modal a bit
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/alicia/dashy/6KF2MNi631bK8Z7FwyoY5fxDmxY2 |
|
✔️ Deploy Preview for dashy-dev ready! 🔨 Explore the source changes: fcfb162 🔍 Inspect the deploy log: https://app.netlify.com/sites/dashy-dev/deploys/60d082fe25ba79000887c226 😎 Browse the preview: https://deploy-preview-43--dashy-dev.netlify.app/ |
This was referenced Jun 21, 2021
asterling8516
pushed a commit
to asterling8516/dashy
that referenced
this pull request
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Category: Feature
Issue Number: #17 , #10 and #36
Briefly outline your changes:
Implements functionality enabling the user to save their config directly to the
conf.ymlfile through the config editor in the UI. This will get rid of annoying issues surrounding config changes only being able to be applied locally, and mean the user no longer has to download their changes and manually insert into the conf.yml file, so it should (hopefully) make the app much more convenient to use.Before submitting, please ensure that: