Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Improved Item Opening Method Options #292

Merged
merged 8 commits into from
Oct 23, 2021

Conversation

Lissy93
Copy link
Owner

@Lissy93 Lissy93 commented Oct 22, 2021

Medium Lissy93 /FEATURE/advanced-item-targets → Lissy93/dashy Commits: 8 | Files Changed: 16 | Additions: 64 ✨ Feature

Category: Feature

Overview

  • Adds support for _top and _parent anchor targets on items
  • Adds appConfig.defaultOpeningMethod option to specify default target
  • Adds new icons to show items opening method on hover
  • Refactors target checking, updates item target docs and schema

Issue Number #289

New Vars

Field Type Required Description
appConfig.defaultOpeningMethod enum Optional The default opening method for items, if no target is specified for a given item. Can be either newtab, sametab, top, parent, modal or workspace. Defaults to newtab
item.target enum Optional The opening method for when the item is clicked, either newtab, sametab, top, parent, modal or workspace.

The list of options for target/ default opening method are:

  • sametab - The app will be launched in the current tab
  • newtab - The app will be launched in a new tab
  • modal - Launch app in a resizable/ movable popup modal on the current page
  • workspace - Changes to Workspace view, and launches app
  • top - Opens in the top-most browsing context, useful if your accessing Dashy through an iframe

Screenshot N/A

Code Quality Checklist (Please complete)

  • All changes are backwards compatible
  • All lint checks and tests are passing
  • There are no (new) build warnings or errors
  • (If a new config option is added) Attribute is outlined in the schema and documented
  • (If a new dependency is added) Package is essential, and has been checked out for security or performance
  • Bumps version, if new feature added

@netlify
Copy link

netlify bot commented Oct 22, 2021

✔️ Deploy Preview for dashy-dev ready!

🔨 Explore the source changes: 3f35f99

🔍 Inspect the deploy log: https://app.netlify.com/sites/dashy-dev/deploys/617333efe5870d00070687e2

😎 Browse the preview: https://deploy-preview-292--dashy-dev.netlify.app

@liss-bot
Copy link
Collaborator

Hi Lissy93! Thank you for contributing to Dashy! ✨

When making changes to the documentation, be sure to double check that:

  • Link and images URLs properly resolve
  • Your spelling and grammar is correct
  • Any markdown formatting is valid

Don't forget to verify they the config validator script responds correctly to your new attribute.


I'm a bot, and this is an automated comment 🤖

@liss-bot liss-bot added the ✨ New Feature [PR] Contains implementation of a new feature label Oct 22, 2021
@viezly
Copy link

viezly bot commented Oct 22, 2021

This pull request is split into 3 parts for easier review.
👀 Review pull request on Viezly

Changed files are located in these folders:

  • /
  • docs
  • src/assets/interface-icons
  • src/components
  • src/utils

Copy link
Owner Author

@Lissy93 Lissy93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and confirmed working with no regressions.

@liss-bot
Copy link
Collaborator

LGTM

Repository owner deleted a comment from liss-bot Oct 22, 2021
@liss-bot
Copy link
Collaborator

Size Change: +1.3 kB (0%)

Total Size: 1.95 MB

Filename Size Change
./dist/js/dashy.********.js 105 kB +1.3 kB (+1%)
./dist/precache-********.91411c010f6c8237aae65b09fa4299d2.js 0 B -3.46 kB (removed) 🏆
./dist/precache-********.3fb95b6fc39fe442a1cba9c6eb4b2964.js 3.46 kB +3.46 kB (new file) 🆕
ℹ️ View Unchanged
Filename Size Change
./dist/css/chunk-********.6fea770a.css 98 B 0 B
./dist/css/chunk-********.a64c098d.css 348 B 0 B
./dist/css/chunk-********.f5d4b402.css 899 B 0 B
./dist/css/chunk-vendors.********.css 847 B 0 B
./dist/css/dashy.********.css 21.7 kB 0 B
./dist/default.html 2.61 kB 0 B
./dist/index.html 1.13 kB 0 B
./dist/js/chunk-********.f26de106.js 406 B 0 B
./dist/js/chunk-********.7d46509e.js 2.05 kB 0 B
./dist/js/chunk-********.b26a5777.js 591 B 0 B
./dist/js/chunk-vendors.********.js 1.81 MB 0 B
./dist/service-worker.js 619 B -2 B (0%)

compressed-size-action

@Lissy93 Lissy93 deleted the FEATURE/advanced-item-targets branch October 23, 2021 00:45
@liss-bot
Copy link
Collaborator

The fix for this issue has now been released in Dashy 1.9.0 ✨

If you haven't done so already, please update your instance to 1.9.0 or later. See Dashy 1.9.0 for full info.

Feel free to reach out if you need any more support. If you are enjoying Dashy, consider supporting the project.

asterling8516 pushed a commit to asterling8516/dashy that referenced this pull request Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants