Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature support cloud services #29

Merged
merged 5 commits into from
Jun 11, 2021
Merged

Conversation

Lissy93
Copy link
Owner

@Lissy93 Lissy93 commented Jun 11, 2021

Please check the type of change your PR introduces:

  • Bugfix
  • Build related changes
  • Documentation content changes

Issue Number (if applicable): N/A

Briefly outline your changes:

  • Fix an issue with the port not being correctly assigned to system environmental variable, due to misplaced bracket
  • Added support for 1-Click deployment to Heroku, Netlify and PWD

Before submitting, please ensure that:

  • Must be backwards compatible
  • All lint checks and tests must pass
  • If a new option in the the config file is added, it needs to be added into the schema, and documented in the configuring guide
  • If a new dependency is required, it must be essential, and it must be thoroughly checked out for security or efficiency issues

Missing brackets in server.js (L15) was causing the port to not be read from ENV varaiable PORT correctly, effectively breaking deployment builds. Bloody JavaScript...
@netlify
Copy link

netlify bot commented Jun 11, 2021

❌ Deploy Preview for dashy-dev failed.

🔨 Explore the source changes: 94dc0e7

🔍 Inspect the deploy log: https://app.netlify.com/sites/dashy-dev/deploys/60c3c9c7be5427000707bf71

@Lissy93 Lissy93 merged commit 866f23d into master Jun 11, 2021
@Lissy93 Lissy93 deleted the feature_support-cloud-services branch June 12, 2021 11:42
asterling8516 pushed a commit to asterling8516/dashy that referenced this pull request Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant