Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REFACTOR] Improved Language Detection #223

Merged
merged 9 commits into from
Sep 11, 2021

Conversation

Lissy93
Copy link
Owner

@Lissy93 Lissy93 commented Sep 11, 2021

Lissy93 /REFACTOR/improved-language-detection → Lissy93/dashy Commits: 9 | Files Changed: 9 | Additions: 80 🚚 Refactor Powered by Pull Request Badge

Category: Refactoring

Overview

  • Makes the auto language detection algo smarter
  • Improves responsiveness for the language selector form
  • Also adds a tag to error handler, and a contents page to Config docs

Issue Number N/A

New Vars N/A

Screenshot N/A

Code Quality Checklist (Please complete)

  • All changes are backwards compatible
  • All lint checks and tests are passing
  • There are no (new) build warnings or errors
  • (If a new config option is added) Attribute is outlined in the schema and documented
  • (If a new dependency is added) Package is essential, and has been checked out for security or performance
  • Bumps version, if new feature added

@Lissy93 Lissy93 added the 🚚 Refactor [PR] Non-feature code-related updates and refactoring label Sep 11, 2021
@netlify
Copy link

netlify bot commented Sep 11, 2021

✔️ Deploy Preview for dashy-dev ready!

🔨 Explore the source changes: 5a8e24b

🔍 Inspect the deploy log: https://app.netlify.com/sites/dashy-dev/deploys/613bffb057028b0008da722d

😎 Browse the preview: https://deploy-preview-223--dashy-dev.netlify.app/

@viezly
Copy link

viezly bot commented Sep 11, 2021

Changes preview:

👀 Review pull request on Viezly

Repository owner deleted a comment from liss-bot Sep 11, 2021
Repository owner deleted a comment from liss-bot Sep 11, 2021
@Lissy93 Lissy93 merged commit 51e2129 into master Sep 11, 2021
@Lissy93 Lissy93 deleted the REFACTOR/improved-language-detection branch September 11, 2021 01:14
asterling8516 pushed a commit to asterling8516/dashy that referenced this pull request Nov 23, 2023
Closes Lissy93#223

Signed-off-by: Bjorn Lammers <walkxnl@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚚 Refactor [PR] Non-feature code-related updates and refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant