Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Adds support for custom sort order for items #203

Merged
merged 13 commits into from
Sep 5, 2021

Conversation

Lissy93
Copy link
Owner

@Lissy93 Lissy93 commented Sep 5, 2021

Lissy93 /FEATURE/smart-sort → Lissy93/dashy Commits: 13 | Files Changed: 14 | Additions: 146 Powered by Pull Request Badge

Category: Feature

Overview
Adds option for user to specify sortBy to order items within a section. Can sort by last clicked, most used, alphabetically and more

Issue Number N/A

New Vars

Field Type Required Description
section.displayData.sortBy string Optional The sort order for items within the current section. By default items are displayed in the order in which they are listed in within the config. The following sort options are supported: most-used (most opened apps first), last-used (the most recently used apps), alphabetical, reverse-alphabetical, random and default
appConfig.disableSmartSort boolean Optional For the most-used and last-used app sort functions to work, a basic open-count is stored in local storage. If you do not want this to happen, then disable smart sort here, but you wil no longer be able to use these sort options. Defaults to false.

Screenshot N/A

Code Quality Checklist (Please complete)

  • All changes are backwards compatible
  • All lint checks and tests are passing
  • There are no (new) build warnings or errors
  • (If a new config option is added) Attribute is outlined in the schema and documented
  • (If a new dependency is added) Package is essential, and has been checked out for security or performance
  • Bumps version, if new feature added

@Lissy93 Lissy93 added the ✨ New Feature [PR] Contains implementation of a new feature label Sep 5, 2021
@netlify
Copy link

netlify bot commented Sep 5, 2021

✔️ Deploy Preview for dashy-dev ready!

🔨 Explore the source changes: 98d0c74

🔍 Inspect the deploy log: https://app.netlify.com/sites/dashy-dev/deploys/6134ef12ddec140008527fe8

😎 Browse the preview: https://deploy-preview-203--dashy-dev.netlify.app/

@viezly
Copy link

viezly bot commented Sep 5, 2021

Changes preview:

👀 Review pull request on Viezly

@Lissy93 Lissy93 merged commit 4004b1c into master Sep 5, 2021
@Lissy93 Lissy93 deleted the FEATURE/smart-sort branch September 5, 2021 16:41
asterling8516 pushed a commit to asterling8516/dashy that referenced this pull request Nov 23, 2023
Closes Lissy93#203

Signed-off-by: Bjorn Lammers <walkxnl@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ New Feature [PR] Contains implementation of a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant