🔧 add OIDC scope option #1641
Merged
🔧 add OIDC scope option #1641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dashy-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Lissy93
approved these changes
Jul 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Category:
New configuration option
Overview
Add an option to customise the requested OIDC scopes.
As of today, Dashy always ask for a lot of scopes (
openid profile email roles groups) that the user might not be willing to configure. This PR gives more flexibility to the user, allowing him to decide which scopes to request.New Vars
New config option :
scope,string: The scope(s) to request from the OIDC providerBy default,
oidc-client-tsdefaults the scope toopenid, there is thus no breaking change.Code Quality Checklist (Please complete)