Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SECURITY] Improve Robustness of Auth Checking #113

Merged
merged 4 commits into from
Aug 1, 2021

Conversation

Lissy93
Copy link
Owner

@Lissy93 Lissy93 commented Aug 1, 2021

Category:

One of: Security

Overview

  • Use both username + password for generating token, so that a change in either will log the user out
  • Prevent privilege escalation by disallowing a user from modifying their user type through the UI
  • Improve the isAuthenticated check, by taking account of empty users array

Issue Number N/A

New Vars N/A

Screenshot N/A

Code Quality Checklist (Please complete)

  • All changes are backwards compatible
  • All lint checks and tests are passing
  • There are no (new) build warnings or errors
  • (If a new config option is added) Attribute is outlined in the schema and documented
  • (If a new dependency is added) Package is essential, and has been checked out for security or performance
  • Bumps version, if new feature added

@netlify
Copy link

netlify bot commented Aug 1, 2021

✔️ Deploy Preview for dashy-dev ready!

🔨 Explore the source changes: 87f6438

🔍 Inspect the deploy log: https://app.netlify.com/sites/dashy-dev/deploys/6106b0abba4ca9000772d2cd

😎 Browse the preview: https://deploy-preview-113--dashy-dev.netlify.app/

@Lissy93 Lissy93 merged commit fe48310 into master Aug 1, 2021
@Lissy93 Lissy93 deleted the FIX/auth-security-fix branch August 1, 2021 14:42
asterling8516 pushed a commit to asterling8516/dashy that referenced this pull request Nov 23, 2023
Closes Lissy93#113

Signed-off-by: Bjorn Lammers <walkxnl@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant