Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't warn about warnings #964

Merged
merged 3 commits into from
May 11, 2023
Merged

Don't warn about warnings #964

merged 3 commits into from
May 11, 2023

Conversation

qxcv
Copy link
Contributor

@qxcv qxcv commented Jan 20, 2023

What does this PR do?

This commit removes UnderReviewWarning from warn_missing_pkg. As far as I can tell, this function is meant to be an internal warning method for other parts of the library to use, and only triggers when the WARN_MISSING_PACKAGE env var is set to something nonzero. Unfortunately, it's also used in many parts of lightning-bolts, and so I (as a user) get maybe 5-10 UnderReviewWarnings every time I import a module, even if warn_missing_pkg wouldn't have warned me about anything otherwise.

The underlying issue is discussed in #563. The current PR does not fix all of #563, but will ameliorate the problem for some users (so #563 should stay open).

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
    • I got ~60% of the way through the tests before the whole thing OOM'd (I only have 10GB of free memory on this machine). I saw a few test failures but they don't seem related to this change & so I assume they existed beforehand (e.g. the tests failed with pytorch-lightning==1.9, so I had to install 1.8.x instead).
  • If you made a notable change (that affects users), did you update the CHANGELOG?

(docs/tests/changelog not touched because this PR doesn't introduce a new feature or any backwards-incompatible changes)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@stale stale bot added the won't fix This will not be worked on label Mar 25, 2023
@Lightning-Universe Lightning-Universe deleted a comment from stale bot Mar 25, 2023
@stale stale bot removed the won't fix This will not be worked on label Mar 25, 2023
@Borda Borda merged commit 3b668ba into Lightning-Universe:master May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants